Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stream: don't emit finish on error #28979

Closed
wants to merge 7 commits into from

Commits on Aug 23, 2019

  1. stream: don't emit finish on error

    After 'error' only 'close' should be emitted.
    ronag committed Aug 23, 2019
    Configuration menu
    Copy the full SHA
    1d9c349 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2019

  1. fixup

    ronag committed Aug 24, 2019
    Configuration menu
    Copy the full SHA
    2ab2399 View commit details
    Browse the repository at this point in the history
  2. fixup: check errorEmitted

    ronag committed Aug 24, 2019
    Configuration menu
    Copy the full SHA
    102b232 View commit details
    Browse the repository at this point in the history
  3. fixup

    ronag committed Aug 24, 2019
    Configuration menu
    Copy the full SHA
    43b1537 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2019

  1. fixup

    ronag committed Aug 30, 2019
    Configuration menu
    Copy the full SHA
    c4a2047 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2019

  1. fixup: docs

    ronag committed Sep 11, 2019
    Configuration menu
    Copy the full SHA
    62d16ec View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2019

  1. Apply suggestions from code review

    Co-Authored-By: Rich Trott <[email protected]>
    ronag and Trott authored Sep 12, 2019
    Configuration menu
    Copy the full SHA
    7b33a42 View commit details
    Browse the repository at this point in the history