deps: V8: workaround V8 leak w track constant fields #28740
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
track_constant_fields exposes a large regression in memory leak due to a suspected memory leak. Disable this until a proper fix is ready. Ref: https://bugs.chromium.org/p/v8/issues/detail?id=9507 Ref: nodejs#28205
nodejs-github-bot
added
build
|
/cc @ulan |
addaleax
approved these changes
Jul 17, 2019
cjihrig
approved these changes
Jul 17, 2019
targos
approved these changes
Jul 18, 2019
|
Root cause turned out to be a bug in angular (see #28205 (comment)). Abandoning. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
track_constant_fieldsexposes a large regression in memory leak dueto a suspected memory leak. Disable this until a proper fix is ready.
Ref: https://bugs.chromium.org/p/v8/issues/detail?id=9507
Ref: #28205
/cc @hashseed @filipesilva
This needs to be backported to v12 once this lands.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes