Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: expose TraceEventHelper with NODE_EXTERN #28724

Closed
wants to merge 2 commits into from
Closed

src: expose TraceEventHelper with NODE_EXTERN #28724

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc63112
src: expose TraceEventHelper with NODE_EXTERN
MarshallOfSound Jul 16, 2019
ddd83f4
fixup! src: expose TraceEventHelper with NODE_EXTERN
Trott Jul 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/tracing/trace_event.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,9 @@ const int kZeroNumArgs = 0;
const decltype(nullptr) kGlobalScope = nullptr;
const uint64_t kNoId = 0;

class TraceEventHelper {
// Extern (for now) because embedders need access to TraceEventHelper.
// Refs: https://github.com/nodejs/node/pull/28724
class NODE_EXTERN TraceEventHelper {
public:
static TracingController* GetTracingController();
static Agent* GetAgent();
Expand Down