Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buffer: construct Buffers in JS #2866

Closed
wants to merge 1 commit into from
Closed

buffer: construct Buffers in JS #2866

wants to merge 1 commit into from

Commits on Sep 15, 2015

  1. buffer: construct Uint8Array in JS 

    Overall construction time of Typed Arrays is faster in JS, but the
problem with using it normally is zero-fill of memory. Get around this
by using a flag in the ArrayBuffer::Allocator to trigger when memory
should or shouldn't be zero-filled.

Remove Buffer::Create() as it is no longer called.

The creation of the Uint8Array() was done at each callsite because at
the time of this patch there was a performance penalty for centralizing
the call in a single function.
    @trevnorris
    trevnorris committed Sep 15, 2015
    Configuration menu
    Copy the full SHA
    d235fe2 View commit details
    Browse the repository at this point in the history