-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add unrepresented flags docs for configure
#28069
Conversation
configure
@rexagod this looks good to me (modulo lint). Would we be willing to add some similar words to the runtime help? Somewhere near: Lines 684 to 696 in 2c76874
|
@refack Hey! Apologies for the delay, also, I was having a bit of trouble understanding what exactly to add in the Thank you! |
Changing the first commit body! |
developed on ffb1819 by wrapping content for lint tests to pass Refs: nodejs#28069
added documentation to support usage of advanced features of `configure` on Windows Fixes: nodejs#17331
developed on fcc6b1 by wrapping content for lint tests to pass Refs: nodejs#28069
Pinging @refack for a look here. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM although doc/guides/maintaining-the-build-files.md
isn't perhaps the most visible place for it.
Added documentation to support usage of advanced features of `configure` on Windows. PR-URL: #28069 Fixes: #17331 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
Landed in 2c5d35e 🎉 The linter complaint due to recent changes. I fixed these issues while landing. |
Added documentation to support usage of advanced features of `configure` on Windows. PR-URL: #28069 Fixes: #17331 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
Added documentation to support usage of advanced features of `configure` on Windows. PR-URL: #28069 Fixes: #17331 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
Added documentation to support usage of advanced features of `configure` on Windows. PR-URL: #28069 Fixes: #17331 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
configure
on WindowsFixes: #17331
Checklist
/cc @refack