nodejs · targos · Jun 4, 2019 · May 17, 2019 · May 20, 2019 · May 17, 2019
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -8,6 +8,10 @@ const path = require('path');
 const NodePlugin = require('./tools/node_modules/eslint-plugin-node-core');
 NodePlugin.RULES_DIR = path.resolve(__dirname, 'tools', 'eslint-rules');
 
+// The Module._findPath() monkeypatching is to make it so that ESLint will work
+// if invoked by a globally-installed ESLint or ESLint installed elsewhere
+// rather than the one we ship. This makes it possible for IDEs to lint files
+// with our rules while people edit them.
 const ModuleFindPath = Module._findPath;
 const hacks = [
   'eslint-plugin-node-core',
@@ -236,7 +240,7 @@ module.exports = {
       {
         selector: "CallExpression[callee.property.name='strictEqual'][arguments.0.type='Literal']:not([arguments.1.type='Literal']):not([arguments.1.type='ObjectExpression']):not([arguments.1.type='ArrayExpression']):not([arguments.1.type='UnaryExpression'])",
         message: 'The first argument should be the `actual`, not the `expected` value.',
-      }
+      },
     ],
     /* eslint-enable max-len */
     'no-return-await': 'error',

diff --git a/.github/SUPPORT.md b/.github/SUPPORT.md
@@ -0,0 +1,26 @@
+# Support
+
+Node.js contributors have limited availability to address general support
+questions. Please make sure you are using a [currently-supported version of
+Node.js](https://github.com/nodejs/Release#release-schedule).
+
+When looking for support, please first search for your question in these venues:
+
+* [Node.js Website](https://nodejs.org/en/), especially the
+  [API docs](https://nodejs.org/api/)
+* [Node.js Help](https://github.com/nodejs/help)
+* [Open or closed issues in the Node.js GitHub organization](https://github.com/issues?utf8=%E2%9C%93&q=sort%3Aupdated-desc+org%3Anodejs+is%3Aissue)
+
+If you didn't find an answer in the resources above, try these unofficial
+resources:
+
+* [Questions tagged 'node.js' on Stack Overflow](https://stackoverflow.com/questions/tagged/node.js)
+* [#node.js channel on chat.freenode.net](https://webchat.freenode.net?channels=node.js&uio=d4)
+* [Node.js Slack Community](https://node-js.slack.com/)
+  * To register: [nodeslackers.com](http://www.nodeslackers.com/)
+
+GitHub issues are for tracking enhancements and bugs, not general support.
+
+The open source license grants you the freedom to use Node.js. It does not
+guarantee commitments of other people's time. Please be respectful and manage
+your expectations.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -29,7 +29,8 @@ release.
 </tr>
 <tr>
     <td valign="top">
-<b><a href="doc/changelogs/CHANGELOG_V12.md#12.3.1">12.3.1</a></b><br/>
+<b><a href="doc/changelogs/CHANGELOG_V12.md#12.4.0">12.4.0</a></b><br/>
+<a href="doc/changelogs/CHANGELOG_V12.md#12.3.1">12.3.1</a><br/>
 <a href="doc/changelogs/CHANGELOG_V12.md#12.3.0">12.3.0</a><br/>
 <a href="doc/changelogs/CHANGELOG_V12.md#12.2.0">12.2.0</a><br/>
 <a href="doc/changelogs/CHANGELOG_V12.md#12.1.0">12.1.0</a><br/>

diff --git a/README.md b/README.md
@@ -28,37 +28,16 @@ The Node.js project uses an [open governance model](./GOVERNANCE.md). The
   * [Verifying Binaries](#verifying-binaries)
 * [Building Node.js](#building-nodejs)
 * [Security](#security)
+* [Contributing to Node.js](#contributing-to-nodejs)
 * [Current Project Team Members](#current-project-team-members)
   * [TSC (Technical Steering Committee)](#tsc-technical-steering-committee)
   * [Collaborators](#collaborators)
   * [Release Keys](#release-keys)
-* [Contributing to Node.js](#contributing-to-nodejs)
 
 ## Support
 
-Node.js contributors have limited availability to address general support
-questions. Please make sure you are using a [currently-supported version of
-Node.js](https://github.com/nodejs/Release#release-schedule).
-
-When looking for support, please first search for your question in these venues:
-
-* [Node.js Website][]
-* [Node.js Help][]
-* [Open or closed issues in the Node.js GitHub organization](https://github.com/issues?utf8=%E2%9C%93&q=sort%3Aupdated-desc+org%3Anodejs+is%3Aissue)
-
-If you didn't find an answer in the resources above, try these unofficial
-resources:
-
-* [Questions tagged 'node.js' on StackOverflow][]
-* [#node.js channel on chat.freenode.net][]
-* [Node.js Slack Community](https://node-js.slack.com/)
-  * To register: [nodeslackers.com](http://www.nodeslackers.com/)
-
-GitHub issues are for tracking enhancements and bugs, not general support.
-
-The open source license grants you the freedom to use Node.js. It does not
-guarantee commitments of other people's time. Please be respectful and manage
-your expectations.
+Looking for help? Check out the
+[instructions for getting support](.github/SUPPORT.md).
 
 ## Release Types
 
@@ -160,6 +139,12 @@ source and a list of supported platforms.
 For information on reporting security vulnerabilities in Node.js, see
 [SECURITY.md](./SECURITY.md).
 
+## Contributing to Node.js
+
+* [Contributing to the project][]
+* [Working Groups][]
+* [Strategic Initiatives][]
+
 ## Current Project Team Members
 
 For information about the governance of the Node.js project, see
@@ -400,7 +385,7 @@ For information about the governance of the Node.js project, see
 * [Qard](https://github.com/Qard) -
 **Stephen Belanger** &lt;[email protected]&gt; (he/him)
 * [refack](https://github.com/refack) -
-**Refael Ackermann** &lt;[email protected]&gt; (he/him)
+**Refael Ackermann (רפאל פלחי)** &lt;[email protected]&gt; (he/him/הוא/אתה)
 * [richardlau](https://github.com/richardlau) -
 **Richard Lau** &lt;[email protected]&gt;
 * [ronkorving](https://github.com/ronkorving) -
@@ -593,18 +578,8 @@ Other keys used to sign some previous releases:
 * **Timothy J Fontaine** &lt;[email protected]&gt;
 `7937DFD2AB06298B2293C3187D33FF9D0246406D`
 
-## Contributing to Node.js
-
-* [Contributing to the project][]
-* [Working Groups][]
-* [Strategic Initiatives][]
-
 [Code of Conduct]: https://github.com/nodejs/admin/blob/master/CODE_OF_CONDUCT.md
 [Contributing to the project]: CONTRIBUTING.md
-[Node.js Help]: https://github.com/nodejs/help
 [Node.js Foundation]: https://nodejs.org/en/foundation/
-[Node.js Website]: https://nodejs.org/en/
-[Questions tagged 'node.js' on StackOverflow]: https://stackoverflow.com/questions/tagged/node.js
 [Working Groups]: https://github.com/nodejs/TSC/blob/master/WORKING_GROUPS.md
 [Strategic Initiatives]: https://github.com/nodejs/TSC/blob/master/Strategic-Initiatives.md
-[#node.js channel on chat.freenode.net]: https://webchat.freenode.net?channels=node.js&uio=d4
diff --git a/deps/histogram/histogram.gyp b/deps/histogram/histogram.gyp
@@ -3,6 +3,10 @@
     {
       'target_name': 'histogram',
       'type': 'static_library',
+      'cflags': ['-fvisibility=hidden'],
+      'xcode_settings': {
+        'GCC_SYMBOLS_PRIVATE_EXTERN': 'YES',  # -fvisibility=hidden
+      },
       'include_dirs': ['src'],
       'direct_dependent_settings': {
         'include_dirs': [ 'src' ]

diff --git a/doc/api/assert.md b/doc/api/assert.md
@@ -68,7 +68,7 @@ try {
 } catch (err) {
   assert(err instanceof assert.AssertionError);
   assert.strictEqual(err.message, message);
-  assert.strictEqual(err.name, 'AssertionError [ERR_ASSERTION]');
+  assert.strictEqual(err.name, 'AssertionError');
   assert.strictEqual(err.actual, 1);
   assert.strictEqual(err.expected, 2);
   assert.strictEqual(err.code, 'ERR_ASSERTION');

diff --git a/doc/api/cli.md b/doc/api/cli.md
@@ -148,13 +148,6 @@ the ability to import a directory that has an index file.
 
 Please see [customizing esm specifier resolution][] for example usage.
 
-### `--experimental-json-modules`
-<!-- YAML
-added: v12.0.0
--->
-
-Enable experimental JSON support for the ES Module loader.
-
 ### `--experimental-modules`
 <!-- YAML
 added: v8.5.0
@@ -190,6 +183,13 @@ added: v9.6.0
 
 Enable experimental ES Module support in the `vm` module.
 
+### `--experimental-wasm-modules`
+<!-- YAML
+added: v12.3.0
+-->
+
+Enable experimental WebAssembly module support.
+
 ### `--force-fips`
 <!-- YAML
 added: v6.0.0
@@ -252,6 +252,57 @@ new X();
 added: v12.0.0
 -->
 
+### `--heap-prof`
+<!-- YAML
+added: v12.4.0
+-->
+
+> Stability: 1 - Experimental
+
+Starts the V8 heap profiler on start up, and writes the heap profile to disk
+before exit.
+
+If `--heap-prof-dir` is not specified, the generated profile will be placed
+in the current working directory.
+
+If `--heap-prof-name` is not specified, the generated profile will be
+named `Heap.${yyyymmdd}.${hhmmss}.${pid}.${tid}.${seq}.heapprofile`.
+
+```console
+$ node --heap-prof index.js
+$ ls *.heapprofile
+Heap.20190409.202950.15293.0.001.heapprofile
+```
+
+### `--heap-prof-dir`
+<!-- YAML
+added: v12.4.0
+-->
+
+> Stability: 1 - Experimental
+
+Specify the directory where the heap profiles generated by `--heap-prof` will
+be placed.
+
+### `--heap-prof-interval`
+<!-- YAML
+added: v12.4.0
+-->
+
+> Stability: 1 - Experimental
+
+Specify the average sampling interval in bytes for the heap profiles generated
+by `--heap-prof`. The default is 512 * 1024 bytes.
+
+### `--heap-prof-name`
+<!-- YAML
+added: v12.4.0
+-->
+
+> Stability: 1 - Experimental
+
+Specify the file name of the heap profile generated by `--heap-prof`.
+
 Generates a heap snapshot each time the process receives the specified signal.
 `signal` must be a valid signal name. Disabled by default.
 
@@ -271,6 +322,17 @@ This flag exists to aid in experimentation with the internal implementation of
 the Node.js http parser.
 This flag is likely to become a no-op and removed at some point in the future.
 
+### `--http-server-default-timeout=milliseconds`
+<!-- YAML
+added: v12.4.0
+-->
+
+Overrides the default value of `http`, `https` and `http2` server socket
+timeout. Setting the value to 0 disables server socket timeout. Unless
+provided, http server sockets timeout after 120s (2 minutes). Programmatic
+setting of the timeout takes precedence over the value set through this
+flag.
+
 ### `--icu-data-dir=file`
 <!-- YAML
 added: v0.11.15
@@ -921,9 +983,11 @@ Node.js options that are allowed are:
 - `--experimental-repl-await`
 - `--experimental-report`
 - `--experimental-vm-modules`
+- `--experimental-wasm-modules`
 - `--force-fips`
 - `--frozen-intrinsics`
 - `--heapsnapshot-signal`
+- `--http-server-default-timeout`
 - `--icu-data-dir`
 - `--inspect`
 - `--inspect-brk`

diff --git a/doc/api/deprecations.md b/doc/api/deprecations.md
@@ -796,7 +796,9 @@ changes:
 
 Type: Deprecation revoked
 
-The [`fs.lchown(path, uid, gid, callback)`][] API is deprecated.
+The [`fs.lchown(path, uid, gid, callback)`][] API was deprecated. The
+deprecation was revoked because the requisite supporting APIs were added in
+libuv.
 
 <a id="DEP0038"></a>
 ### DEP0038: fs.lchownSync(path, uid, gid)
@@ -816,7 +818,8 @@ changes:
 
 Type: Deprecation revoked
 
-The [`fs.lchownSync(path, uid, gid)`][] API is deprecated.
+The [`fs.lchownSync(path, uid, gid)`][] API was deprecated. The deprecation was
+revoked because the requisite supporting APIs were added in libuv.
 
 <a id="DEP0039"></a>
 ### DEP0039: require.extensions
@@ -1364,7 +1367,7 @@ The `NODE_REPL_MODE` environment variable is used to set the underlying
 removed. Please use `sloppy` instead.
 
 <a id="DEP0066"></a>
-### DEP0066: outgoingMessage.\_headers, outgoingMessage.\_headerNames
+### DEP0066: OutgoingMessage.prototype.\_headers, OutgoingMessage.prototype.\_headerNames
 <!-- YAML
 changes:
   - version: v12.0.0
@@ -1377,15 +1380,18 @@ changes:
 
 Type: Runtime
 
-The `http` module `outgoingMessage._headers` and `outgoingMessage._headerNames`
-properties are deprecated. Use one of the public methods
-(e.g. `outgoingMessage.getHeader()`, `outgoingMessage.getHeaders()`,
-`outgoingMessage.getHeaderNames()`, `outgoingMessage.hasHeader()`,
-`outgoingMessage.removeHeader()`, `outgoingMessage.setHeader()`) for working
-with outgoing headers.
+The `http` module `OutgoingMessage.prototype._headers` and
+`OutgoingMessage.prototype._headerNames` properties are deprecated. Use one of
+the public methods (e.g. `OutgoingMessage.prototype.getHeader()`,
+`OutgoingMessage.prototype.getHeaders()`,
+`OutgoingMessage.prototype.getHeaderNames()`,
+`OutgoingMessage.prototype.hasHeader()`,
+`OutgoingMessage.prototype.removeHeader()`,
+`OutgoingMessage.prototype.setHeader()`) for working with outgoing headers.
 
-The `outgoingMessage._headers` and `outgoingMessage._headerNames` properties
-were never documented as officially supported properties.
+The `OutgoingMessage.prototype._headers` and
+`OutgoingMessage.prototype._headerNames` properties were never documented as
+officially supported properties.
 
 <a id="DEP0067"></a>
 ### DEP0067: OutgoingMessage.prototype.\_renderHeaders
@@ -2317,6 +2323,8 @@ changes:
     description: Runtime deprecation.
 -->
 
+Type: Runtime
+
 The undocumented `net._setSimultaneousAccepts()` function was originally
 intended for debugging and performance tuning when using the `child_process`
 and `cluster` modules on Windows. The function is not generally useful and