-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: remove tls-enable-trace-cli from flaky status #28002
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjihrig
approved these changes
Jun 1, 2019
lpinca
approved these changes
Jun 1, 2019
....and....nope. https://ci.nodejs.org/job/node-test-commit-linux/27996/nodes=centos7-64-gcc6/console test-rackspace-centos7-x64-1 17:17:36 not ok 1855 parallel/test-tls-enable-trace-cli
17:17:36 ---
17:17:36 duration_ms: 0.359
17:17:36 severity: fail
17:17:36 exitcode: 1
17:17:36 stack: |-
17:17:36 (node:25033) Warning: Enabling --trace-tls can expose sensitive data in the resulting log.
17:17:36 Sent Record
17:17:36 Header:
17:17:36 Version = TLS 1.0 (0x301)
17:17:36 Content Type = Handshake (22)
17:17:36 Length = 340
17:17:36 ClientHello, Length=336
17:17:36 client_version=0x303 (TLS 1.2)
17:17:36 Random:
17:17:36 gmt_unix_time=0x850B1D53
17:17:36 random_bytes (len=28): 1E791588A43E8A2DD12650F8BD9B2C4BF662FC08BDC9141B229E97A1
17:17:36 session_id (len=32): 50F773FFEF6D99494B9768BEABF38C33435DAF896508EDE3B372EDC60F7C93E5
17:17:36 cipher_suites (len=118)
17:17:36 {0x13, 0x02} TLS_AES_256_GCM_SHA384
17:17:36 {0x13, 0x03} TLS_CHACHA20_POLY1305_SHA256
17:17:36 {0x13, 0x01} TLS_AES_128_GCM_SHA256
17:17:36 {0xC0, 0x2F} TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256
17:17:36 {0xC0, 0x2B} TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256
17:17:36 {0xC0, 0x30} TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
17:17:36 {0xC0, 0x2C} TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384
17:17:36 {0x00, 0x9E} TLS_DHE_RSA_WITH_AES_128_GCM_SHA256
17:17:36 {0xC0, 0x27} TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256
17:17:36 {0x00, 0x67} TLS_DHE_RSA_WITH_AES_128_CBC_SHA256
17:17:36 {0xC0, 0x28} TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384
17:17:36 {0x00, 0x6B} TLS_DHE_RSA_WITH_AES_256_CBC_SHA256
17:17:36 {0x00, 0xA3} TLS_DHE_DSS_WITH_AES_256_GCM_SHA384
17:17:36 {0x00, 0x9F} TLS_DHE_RSA_WITH_AES_256_GCM_SHA384
17:17:36 {0xCC, 0xA9} TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305_SHA256
17:17:36 {0xCC, 0xA8} TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305_SHA256
17:17:36 {0xCC, 0xAA} TLS_DHE_RSA_WITH_CHACHA20_POLY1305_SHA256
17:17:36 Sent Record
17:17:36 Header:
17:17:36 Version = TLS 1.2 (0x303)
17:17:36 Content Type = ApplicationData (23)
17:17:36 Length = 19
17:17:36 Inner Content Type = Alert (21)
17:17:36 Level=warning(1), description=close notify(0)
17:17:36
17:17:36 Sent Record
17:17:36 Header:
17:17:36 Version = TLS 1.2 (0x303)
17:17:36 Content Type = ApplicationData (23)
17:17:36 Length = 266
17:17:36 Inner Content Type = Handshake (22)
17:17:36 NewSessionTicket, Length=245
17:17:36 ticket_lifetime_hint=7200
17:17:36 ticket_age_add=387409500
17:17:36 ticket_nonce (len=8): 0000000000000000
17:17:36 ticket (len=224): F31FCC7D488C5AC48F8DC958CA9A5F5D4C054F135F678859C6DEF999FD47F796F75BF309089D6BD08CCEE0A33BB959E2C2985BAE6B27AD02B73D41A86F63C51435CA38BBE0A30FB4EDC6EFD4D67A3F9030F804B167EC37A9541D630E29E227F4E928C09C4E82CCE1AB755797D3EE8F94A04E0999F76315CE713FBF09CC661CF61F7994CBA5DE152C8039C572BC8CA135112C1B4915CFEF7A9FDAC5D22B4273B6BE5C3AD66D1F6730F5FB68CBFAEFB6B0807E3E65C9A710F3DECD9DFB3EA28609436AF880882DEED50E989B7145CFAB0ACD84154929FF
17:17:36 (node:25022) internal/test/binding: These APIs are for internal testing only. Do not use them.
17:17:36 assert.js:362
17:17:36 throw err;
17:17:36 ^
17:17:36
17:17:36 AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value:
17:17:36
17:17:36 assert(/Received Record/.test(stderr))
17:17:36
17:17:36 at ChildProcess.<anonymous> (/home/iojs/build/workspace/node-test-commit-linux/nodes/centos7-64-gcc6/test/parallel/test-tls-enable-trace-cli.js:40:3)
17:17:36 at ChildProcess.<anonymous> (/home/iojs/build/workspace/node-test-commit-linux/nodes/centos7-64-gcc6/test/common/index.js:374:15)
17:17:36 at ChildProcess.emit (events.js:200:13)
17:17:36 at maybeClose (internal/child_process.js:1028:16)
17:17:36 at Process.ChildProcess._handle.onexit (internal/child_process.js:283:5) {
17:17:36 generatedMessage: true,
17:17:36 code: 'ERR_ASSERTION',
17:17:36 actual: false,
17:17:36 expected: true,
17:17:36 operator: '=='
17:17:36 }
17:17:36 ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #27636
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes