Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: rename test-performance to test-perf-hooks #27969

Closed
wants to merge 1 commit into from
Closed

test: rename test-performance to test-perf-hooks #27969

wants to merge 1 commit into from

Conversation

ryzokuken
Copy link
Contributor

Rename test-performance to test-perf-hooks to better match its function

Refs: #27884 (comment)

/cc @Trott

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@ryzokuken
test: rename test-performance to test-perf-hooks
e755f75 
Rename test-performance to test-perf-hooks to better match its function

Refs: nodejs#27884 (comment)
@Trott
Copy link
Member

Trott commented May 30, 2019

LGTM but let's ping @nodejs/performance @jasnell just in case....

@ryzokuken
Copy link
Contributor Author

Sure.

@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/23493/

@ZYSzys ZYSzys added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests. labels May 30, 2019
@ryzokuken
Copy link
Contributor Author

Flake in https://ci.nodejs.org/job/node-test-binary-windows-2/1116/COMPILED_BY=vs2017,RUNNER=win2008r2-vs2017,RUN_SUBSET=0/console?

@refack
Copy link
Contributor

refack commented May 31, 2019

Flake

Reminder to rename #25903

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/23524/

@ryzokuken
Copy link
Contributor Author

Passed! Landing this.

@ryzokuken
Copy link
Contributor Author

Landed in 389804e 🎉

@ryzokuken ryzokuken closed this Jun 1, 2019
ryzokuken added a commit that referenced this pull request Jun 1, 2019
@ryzokuken
test: rename test-performance to test-perf-hooks
389804e 
Rename test-performance to test-perf-hooks to better match its function

Refs: #27884 (comment)

PR-URL: #27969
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
targos pushed a commit that referenced this pull request Jun 1, 2019
@ryzokuken @targos
test: rename test-performance to test-perf-hooks
10bdd13 
Rename test-performance to test-perf-hooks to better match its function

Refs: #27884 (comment)

PR-URL: #27969
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@targos targos mentioned this pull request Jun 3, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@cjihrig cjihrig cjihrig approved these changes

@trivikr trivikr trivikr approved these changes

@ZYSzys ZYSzys ZYSzys approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@ryzokuken @Trott @nodejs-github-bot @refack @addaleax @cjihrig @trivikr @ZYSzys