Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meta: create github support file #27926

Closed
wants to merge 3 commits into from
Closed

meta: create github support file #27926

wants to merge 3 commits into from

Conversation

devsnek
Copy link
Member

@devsnek devsnek commented May 27, 2019

@nodejs/tsc @nodejs/community-committee

Refs: https://help.github.com/en/articles/adding-support-resources-to-your-project

Checklist

@devsnek devsnek added the meta Issues and PRs related to the general management of the project. label May 27, 2019
@Trott Trott self-assigned this May 27, 2019
Trott
Trott requested changes May 27, 2019
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The shorthand links won't work without the references at the bottom. I'd inline all of them, though, so that people looking at this in a text editor can understand it easier.

@Trott
Copy link
Member

Trott commented May 27, 2019

(I'd also recommend replacing the information in README with a link to this file so we don't have to update information in two places.)

@Trott
Copy link
Member

Trott commented May 27, 2019 •
edited
Loading

This is what I was going to propose, if it helps: master...Trott:support-file

Trott added a commit to Trott/io.js that referenced this pull request May 27, 2019
@Trott
doc: move support information to SUPPORT.md
13edd42 
The GitHub interface will display links to SUPPORT.md in
hopefully-helpful places so let's take advantage of that and move the
support information to there and out of our README (but include a link
to the new SUPPORT.md).

Fixes: nodejs#27926
@devsnek
meta: create github support file
dd65fdc 
Refs: help.github.com/en/articles/adding-support-resources-to-your-project
@Trott Trott removed their assignment May 27, 2019
@Trott
Copy link
Member

Trott commented May 27, 2019

Looks like maybe the lite CI's didn't start automatically. Here's a manually-started Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3629/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 27, 2019
keywordnew
keywordnew reviewed May 27, 2019
View reviewed changes
Copy link
Contributor

@keywordnew keywordnew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great folks!

My non-blocking comment would be to add what the suggested resources are good for, so unfamiliar people can make better choices without as much guesswork.

For example:

* [Node.js Website](https://nodejs.org/en/)
Good for general information, links to latest changelogs, API docs.

bnb
bnb approved these changes May 27, 2019
View reviewed changes
Copy link
Contributor

@bnb bnb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than these small changes, LGTM.

.github/SUPPORT.md Show resolved Hide resolved
.github/SUPPORT.md Outdated Show resolved Hide resolved
@bnb
Copy link
Contributor

bnb commented May 27, 2019

Thank you @devsnek for PRng this in! 💖

@devsnek @bnb
Update .github/SUPPORT.md
082675a 
Co-Authored-By: Tierney Cyren <[email protected]>
Trott
Trott reviewed May 28, 2019
View reviewed changes
.github/SUPPORT.md Outdated Show resolved Hide resolved
@devsnek @Trott
Update .github/SUPPORT.md
c19ddef 
Co-Authored-By: Rich Trott <[email protected]>
watilde
watilde approved these changes May 28, 2019
View reviewed changes
Copy link
Member

@watilde watilde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3

@Trott
Copy link
Member

Trott commented May 28, 2019

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3631/

mcollina
mcollina approved these changes May 28, 2019
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Trott
Copy link
Member

Trott commented May 30, 2019 •
edited
Loading

Landed in f469522

@Trott Trott closed this May 30, 2019
Trott pushed a commit to Trott/io.js that referenced this pull request May 30, 2019
@devsnek @Trott
meta: create github support file
f469522 
PR-URL: nodejs#27926
Refs: https://help.github.com/en/articles/adding-support-resources-to-your-project
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
targos pushed a commit that referenced this pull request May 31, 2019
@devsnek @targos
meta: create github support file
d982f0b 
PR-URL: #27926
Refs: https://help.github.com/en/articles/adding-support-resources-to-your-project
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@devsnek devsnek deleted the support-file branch June 1, 2019 14:08
@targos targos mentioned this pull request Jun 3, 2019
Merged
@richardlau richardlau mentioned this pull request Jun 3, 2019
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnb bnb bnb approved these changes

@Trott Trott Trott approved these changes

@keywordnew keywordnew keywordnew left review comments

@mcollina mcollina mcollina approved these changes

@watilde watilde watilde approved these changes

@cjihrig cjihrig cjihrig approved these changes

@WaleedAshraf WaleedAshraf WaleedAshraf approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@devsnek @Trott @bnb @mcollina @watilde @cjihrig @WaleedAshraf @BridgeAR @keywordnew @trivikr