Fix http docs #27918
Closed
Fix http docs #27918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mscdex
reviewed
May 26, 2019
| @@ -2061,8 +2061,13 @@ order: | |||
| (`'data'` will not be emitted at all if the response body is empty, for | |||
| instance, in most redirects) | |||
| * `'end'` on the `res` object | |||
| * `'error'` if the server response is received while still writing to request. | |||
There was a problem hiding this comment.
I'm not sure that this belongs here as it's a list of events for a successful request.
There was a problem hiding this comment.
depends on what you define as a successful request, anything that has a response is successful?
There was a problem hiding this comment.
I would say any request and response that completes without any 'error' events.
|
Since this behavior is now considered a bug (see #27916) this PR is no longer relevant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documents a weird http behaviour. See, #27916