Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix arguments order of comparsion functions #27907

Merged
merged 1 commit into from
May 27, 2019
Merged

test: fix arguments order of comparsion functions #27907

merged 1 commit into from
May 27, 2019

Conversation

m0rtyn
Copy link
Contributor

@m0rtyn m0rtyn commented May 26, 2019

Place actual values as the first arguments and expected as the second.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label May 26, 2019
@BridgeAR BridgeAR added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label May 26, 2019
ryzokuken
ryzokuken approved these changes May 26, 2019
View reviewed changes
Copy link
Contributor

@ryzokuken ryzokuken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 27, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/23374/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/23397/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/23413/

@ChALkeR
Copy link
Member

ChALkeR commented May 27, 2019

Please react with 👍for fast-tracking.

@ChALkeR ChALkeR added the fast-track PRs that do not need to wait for 48 hours to land. label May 27, 2019
@m0rtyn @ChALkeR
test: fix arguments order of comparsion functions
d6cc6ab 
Place actual values as the first agruments and expected as the second.

PR-URL: nodejs#27907
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
@ChALkeR ChALkeR force-pushed the fix-arguments-order-in-comparsion-functions branch from 6ac4567 to d6cc6ab Compare May 27, 2019 21:35
@ChALkeR ChALkeR merged commit d6cc6ab into nodejs:master May 27, 2019
@ChALkeR
Copy link
Member

ChALkeR commented May 27, 2019

Landed in d6cc6ab.

Thanks for the contribution! 🎉

https://www.nodetodo.org/next-steps/ is a good list of ideas on possible next steps. (But the next steps are not limited to just that list -- you can always come up with your own)!

targos pushed a commit that referenced this pull request May 28, 2019
@m0rtyn @targos
test: fix arguments order of comparsion functions
652cadb 
Place actual values as the first agruments and expected as the second.

PR-URL: #27907
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
@targos targos mentioned this pull request Jun 3, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryzokuken ryzokuken ryzokuken approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@cjihrig cjihrig cjihrig approved these changes

@Trott Trott Trott approved these changes

@ChALkeR ChALkeR ChALkeR approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@m0rtyn @nodejs-github-bot @ChALkeR @Trott @cjihrig @gireeshpunathil @BridgeAR @ryzokuken