Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: cover import of a *.node file with a policy manifest #27903

Closed
wants to merge 2 commits into from
Closed

test: cover import of a *.node file with a policy manifest #27903

wants to merge 2 commits into from

Conversation

zeckson
Copy link
Contributor

@zeckson zeckson commented May 26, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label May 26, 2019
ryzokuken
ryzokuken reviewed May 26, 2019
View reviewed changes
Copy link
Contributor

@ryzokuken ryzokuken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

/cc @nodejs/n-api

@ryzokuken ryzokuken added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label May 26, 2019
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@ChALkeR ChALkeR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 27, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/23422/

@Trott
Copy link
Member

Trott commented May 30, 2019

Landed in 6a3d7cf

Trott pushed a commit to Trott/io.js that referenced this pull request May 30, 2019
@zeckson @Trott
test: cover import of a *.node file with a policy manifest
6a3d7cf 
Cover import of a *.node file with a policy manifest. Add invalid
integrity test case.

PR-URL: nodejs#27903
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@Trott Trott closed this May 30, 2019
targos pushed a commit that referenced this pull request May 31, 2019
@zeckson @targos
test: cover import of a *.node file with a policy manifest
0d74198 
Cover import of a *.node file with a policy manifest. Add invalid
integrity test case.

PR-URL: #27903
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@targos targos mentioned this pull request Jun 3, 2019
Merged
@zeckson zeckson deleted the test-node-policy branch June 18, 2019 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryzokuken ryzokuken ryzokuken left review comments

@Trott Trott Trott approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@zeckson @nodejs-github-bot @Trott @addaleax @ryzokuken @ChALkeR