Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix typo in pipe from async iterator example #27870

Closed
wants to merge 1 commit into from
Closed

doc: fix typo in pipe from async iterator example #27870

wants to merge 1 commit into from

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented May 25, 2019

value -> chunk.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/23362/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 27, 2019
@lpinca
Copy link
Member Author

lpinca commented May 29, 2019

Landed in eb4c1d5.

@lpinca lpinca closed this May 29, 2019
@lpinca lpinca deleted the fix/typo branch May 29, 2019 06:43
lpinca added a commit that referenced this pull request May 29, 2019
@lpinca
doc: fix typo in pipe from async iterator example
eb4c1d5 
PR-URL: #27870
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
targos pushed a commit that referenced this pull request May 31, 2019
@lpinca @targos
doc: fix typo in pipe from async iterator example
b7cd0de 
PR-URL: #27870
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@targos targos mentioned this pull request Jun 3, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@addaleax addaleax addaleax approved these changes

@antsmartian antsmartian antsmartian approved these changes

@cjihrig cjihrig cjihrig approved these changes

@ZYSzys ZYSzys ZYSzys approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@lpinca @nodejs-github-bot @Trott @addaleax @antsmartian @cjihrig @ZYSzys