inspector: more conservative minimum stack size #27855
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
|
Related: libuv/libuv#2310 |
cjihrig
approved these changes
May 24, 2019
jasnell
approved these changes
May 24, 2019
eugeneo
approved these changes
May 24, 2019
|
Re-run to check if the freebsd failures are flakes or regressions: https://ci.nodejs.org/job/node-test-pull-request/23324/ |
bnoordhuis
force-pushed
the
min-thread-stack-size
branch
from
da49258
to
e943c71
Compare
|
I guess freebsd doesn't like small stacks... I decided to leave well enough alone. |
addaleax
approved these changes
May 26, 2019
| // creating a big 2 or 4 MB address space gap (problematic on 32 bits | ||
| // because of fragmentation), not squeeze out every last byte. | ||
| const size_t stack_size = std::max(static_cast<size_t>(4 * 8192), | ||
| static_cast<size_t>(PTHREAD_STACK_MIN)); |
There was a problem hiding this comment.
I guess this doesn’t change anything compared to the current situation, but should we do something like libuv/libuv@38bb0f5 (use PTHREAD_STACK_MIN only inside an #ifdef)?
There was a problem hiding this comment.
Fair point. Addressed in the fix-up commit.
PTHREAD_STACK_MIN is 2 KB with musl, which is too small to safely receive signals. PTHREAD_STACK_MIN + MINSIGSTKSZ is 8 KB on arm64, which is the musl architecture with the biggest MINSIGSTKSZ so let's use that as a lower bound and let's quadruple it just in case.
bnoordhuis
force-pushed
the
min-thread-stack-size
branch
from
e943c71
to
ee68f56
Compare
bnoordhuis
added
the
author ready
Trott
approved these changes
Jun 2, 2019
|
Landed in 5539d7e |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Jun 2, 2019
PTHREAD_STACK_MIN is 2 KB with musl, which is too small to safely receive signals. PTHREAD_STACK_MIN + MINSIGSTKSZ is 8 KB on arm64, which is the musl architecture with the biggest MINSIGSTKSZ so let's use that as a lower bound and let's quadruple it just in case. PR-URL: nodejs#27855 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Eugene Ostroukhov <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jun 3, 2019
PTHREAD_STACK_MIN is 2 KB with musl, which is too small to safely receive signals. PTHREAD_STACK_MIN + MINSIGSTKSZ is 8 KB on arm64, which is the musl architecture with the biggest MINSIGSTKSZ so let's use that as a lower bound and let's quadruple it just in case. PR-URL: #27855 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Eugene Ostroukhov <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Flarna
pushed a commit
to dynatrace-oss-contrib/node
that referenced
this pull request
Jun 4, 2020
PTHREAD_STACK_MIN is 2 KB with musl, which is too small to safely receive signals. PTHREAD_STACK_MIN + MINSIGSTKSZ is 8 KB on arm64, which is the musl architecture with the biggest MINSIGSTKSZ so let's use that as a lower bound and let's quadruple it just in case. Backport-PR-URL: nodejs#33720 PR-URL: nodejs#27855 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Eugene Ostroukhov <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]>
richardlau
pushed a commit
that referenced
this pull request
Jul 1, 2020
PTHREAD_STACK_MIN is 2 KB with musl, which is too small to safely receive signals. PTHREAD_STACK_MIN + MINSIGSTKSZ is 8 KB on arm64, which is the musl architecture with the biggest MINSIGSTKSZ so let's use that as a lower bound and let's quadruple it just in case. Backport-PR-URL: #33720 PR-URL: #27855 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Eugene Ostroukhov <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PTHREAD_STACK_MIN is 2 KB with musl, which is too small to safely
receive signals. PTHREAD_STACK_MIN + MINSIGSTKSZ is 8 KB on arm64,
which is the musl architecture with the biggest MINSIGSTKSZ so let's
use that as a lower bound and let's quadruple it just in case.
This coincidentally also lets us remove a FreeBSD-specific workaround.