child_process: move exports to bottom for better code style #27845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
child_process
mscdex
reviewed
May 24, 2019
jasnell
reviewed
May 24, 2019
jasnell
added
the
semver-major
himself65
force-pushed
the
27639
branch
2 times, most recently
from
fe39082
to
897ca32
Compare
targos
approved these changes
May 25, 2019
targos
removed
the
semver-major
Trott
reviewed
May 25, 2019
himself65
force-pushed
the
27639
branch
2 times, most recently
from
be8b3cb
to
6780a11
Compare
BridgeAR
approved these changes
May 29, 2019
|
@himself65 it seems like this needs a rebase :) |
|
@BridgeAR thanks. rebased |
Trott
approved these changes
May 30, 2019
This comment has been minimized.
This comment has been minimized.
ZYSzys
approved these changes
May 30, 2019
This comment has been minimized.
This comment has been minimized.
|
Landed in aa00968 |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Jun 2, 2019
PR-URL: nodejs#27845 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jun 3, 2019
PR-URL: #27845 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes