Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

win,msi: fix documentation shortcut url #2781

Closed
wants to merge 1 commit into from
Closed

Conversation

mscdex
Copy link
Contributor

@mscdex mscdex commented Sep 9, 2015

No description provided.

@mscdex
Copy link
Contributor Author

mscdex commented Sep 9, 2015

Fixes #2779.

@mscdex mscdex added windows Issues and PRs related to the Windows platform. build Issues and PRs related to build files or the CI. labels Sep 9, 2015
@mscdex mscdex changed the title win,msi: Fix documentation shortcut url win,msi: fix documentation shortcut url Sep 10, 2015
@rvagg
Copy link
Member

rvagg commented Sep 10, 2015

This is not the correct fix, the correct one is simply to change:

Target="https://nodejs.org/download/$(var.DistTypeDir)/v$(var.FullVersion)/doc/api/"
Target="https://nodejs.org/download/$(var.DistTypeDir)/v$(var.FullVersion)/docs/api/"

i.e. docs not doc

It's intended to work for all release types, not just general releases but also nightlies, release candidates etc.

@rvagg
Copy link
Member

rvagg commented Sep 10, 2015

^ the history of this error is that io.js always shipped with "doc" matching the name of the dir in the repo but node.js shipped with "docs" and we've moved to the latter for both now, the msi changes went in to io.js pre merge

@mscdex
Copy link
Contributor Author

mscdex commented Sep 10, 2015

Updated.

@rvagg
Copy link
Member

rvagg commented Sep 10, 2015

lgtm

mscdex added a commit that referenced this pull request Sep 10, 2015
@mscdex
Copy link
Contributor Author

mscdex commented Sep 10, 2015

Landed in 81a0c0b.

@mscdex mscdex closed this Sep 10, 2015
@mscdex mscdex deleted the fix-win-docs-shortcut branch September 10, 2015 04:38
mscdex added a commit that referenced this pull request Sep 11, 2015
mscdex added a commit that referenced this pull request Sep 12, 2015
@rvagg rvagg mentioned this pull request Sep 12, 2015
@Fishrock123 Fishrock123 mentioned this pull request Sep 13, 2015
7 tasks
@rvagg rvagg mentioned this pull request Sep 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants