src: ignore SIGXFSZ, don't terminate (ulimit -f) #27798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
c++
richardlau
approved these changes
May 21, 2019
| const cmd = `ulimit -f 1 && '${process.execPath}' '${__filename}' child`; | ||
| const result = child_process.spawnSync('/bin/sh', ['-c', cmd]); | ||
| assert.strictEqual(result.stdout.toString(), ''); | ||
| const shibboleth = 'Error: EFBIG: file too large, write'; |
There was a problem hiding this comment.
Please rename this variable to something boring like error or errormsg.
addaleax
approved these changes
May 21, 2019
BridgeAR
approved these changes
May 21, 2019
cjihrig
approved these changes
May 21, 2019
|
Added more bore. New CI: https://ci.nodejs.org/job/node-test-pull-request/23257/ |
richardlau
approved these changes
May 21, 2019
|
One more test fix-up for shared library mode: https://ci.nodejs.org/job/node-test-pull-request/23258/ |
lpinca
approved these changes
May 22, 2019
Ignore SIGXFSZ signals so that exceeding RLIMIT_FSIZE makes the offending system call fail with EFBIG instead of terminating the process. PR-URL: nodejs#27798 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
bnoordhuis
force-pushed
the
ignore-sigxfsz
branch
from
f79e770
to
58fe440
Compare
|
Thanks, landed in 58fe440. |
targos
pushed a commit
that referenced
this pull request
May 23, 2019
Ignore SIGXFSZ signals so that exceeding RLIMIT_FSIZE makes the offending system call fail with EFBIG instead of terminating the process. PR-URL: #27798 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore SIGXFSZ signals so that exceeding RLIMIT_FSIZE makes the
offending system call fail with EFBIG instead of terminating the
process.