Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

n-api: DRY napi_coerce_to_x() API methods #27796

Closed
wants to merge 1 commit into from
Closed

n-api: DRY napi_coerce_to_x() API methods #27796

wants to merge 1 commit into from

Conversation

bnoordhuis
Copy link
Member

No description provided.

@nodejs-github-bot
Copy link
Collaborator

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3585

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label May 21, 2019
@bnoordhuis bnoordhuis added the node-api Issues and PRs related to the Node-API. label May 21, 2019
mhdawson
mhdawson approved these changes May 22, 2019
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/23291/

@danbev
Copy link
Contributor

danbev commented May 24, 2019

Landed in c56474f.

@danbev danbev closed this May 24, 2019
danbev pushed a commit that referenced this pull request May 24, 2019
@bnoordhuis @danbev
n-api: DRY napi_coerce_to_x() API methods
c56474f 
PR-URL: #27796
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@bnoordhuis bnoordhuis deleted the dry-napi-coerce branch May 24, 2019 15:25
targos pushed a commit that referenced this pull request May 28, 2019
@bnoordhuis @targos
n-api: DRY napi_coerce_to_x() API methods
2b7ad12 
PR-URL: #27796
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Jun 3, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@mhdawson mhdawson mhdawson approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. node-api Issues and PRs related to the Node-API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@bnoordhuis @nodejs-github-bot @danbev @jasnell @lpinca @cjihrig @mhdawson