Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http2: support net.Server options #27782

Closed
wants to merge 1 commit into from
Closed

http2: support net.Server options #27782

wants to merge 1 commit into from

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented May 20, 2019

Make http2.createServer() support net.Server options.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@lpinca
http2: support net.Server options
f2de36d 
Make `http2.createServer()` support `net.Server` options.
@nodejs-github-bot
Copy link
Collaborator

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3576

@nodejs-github-bot nodejs-github-bot added the http2 Issues or PRs related to the http2 subsystem. label May 20, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/23239/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/23267/

@trivikr trivikr added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 22, 2019
@danbev
Copy link
Contributor

danbev commented May 23, 2019

Landed in 165916b.

@danbev danbev closed this May 23, 2019
danbev pushed a commit that referenced this pull request May 23, 2019
@lpinca @danbev
http2: support net.Server options
165916b 
Make `http2.createServer()` support `net.Server` options.

PR-URL: #27782
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@lpinca lpinca deleted the pass/options-to-parent-ctor branch May 23, 2019 05:48
targos pushed a commit that referenced this pull request May 28, 2019
@lpinca @targos
http2: support net.Server options
8c35198 
Make `http2.createServer()` support `net.Server` options.

PR-URL: #27782
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@targos targos mentioned this pull request Jun 3, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@addaleax addaleax addaleax approved these changes

@cjihrig cjihrig cjihrig approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@trivikr trivikr trivikr approved these changes

@ZYSzys ZYSzys ZYSzys approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. http2 Issues or PRs related to the http2 subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@lpinca @nodejs-github-bot @danbev @Trott @addaleax @cjihrig @BridgeAR @trivikr @ZYSzys