Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: histogram: unexport symbols #27779

Merged
merged 1 commit into from
May 23, 2019
Merged

deps: histogram: unexport symbols #27779

merged 1 commit into from
May 23, 2019

Conversation

bnoordhuis
Copy link
Member

@nodejs-github-bot
Copy link
Collaborator

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3572

@bnoordhuis
Copy link
Member Author

✖ 2:7 Fixes must be a GitHub URL. fixes-url

Linter failure is addressed by nodejs/core-validate-commit#61.

@richardlau
Copy link
Member

✖ 2:7 Fixes must be a GitHub URL. fixes-url

Linter failure is addressed by nodejs/core-validate-commit#61.

I've released a new version of core-validate-commit containing nodejs/core-validate-commit#55 and reran the Travis linter job (which now passes).

@trivikr trivikr added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 21, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/23290/

@bnoordhuis
deps: histogram: unexport symbols
ca8e33a 
Fixes: nodejs/node-gyp#1755
Fixes: nodejs#27778
PR-URL: nodejs#27779
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@bnoordhuis bnoordhuis closed this May 23, 2019
@bnoordhuis bnoordhuis deleted the fix27778 branch May 23, 2019 09:24
@bnoordhuis bnoordhuis merged commit ca8e33a into nodejs:master May 23, 2019
targos pushed a commit that referenced this pull request May 23, 2019
@bnoordhuis @targos
deps: histogram: unexport symbols
3b6424f 
Fixes: nodejs/node-gyp#1755
Fixes: #27778
PR-URL: #27779
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@targos targos mentioned this pull request Jun 3, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@cjihrig cjihrig cjihrig approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@richardlau richardlau richardlau approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

build: histogram: unexport symbols node-gyp links to node version of hdr_histogram, not local version
8 participants
@bnoordhuis @nodejs-github-bot @richardlau @jasnell @addaleax @cjihrig @joyeecheung @trivikr