Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meta: move chrisdickinson to Collaborator Emeriti list #27703

Closed
wants to merge 1 commit into from
Closed

meta: move chrisdickinson to Collaborator Emeriti list #27703

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented May 14, 2019

Chris confirmed in email that he could be moved to Collaborator Emeritus
status.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3522

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label May 14, 2019
@Trott Trott added the meta Issues and PRs related to the general management of the project. label May 14, 2019
@Trott Trott requested a review from chrisdickinson May 14, 2019 21:58
@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 14, 2019
@Trott
meta: move chrisdickinson to Collaborator Emeriti list
ebe8741 
Chris confirmed in email that he could be moved to Collaborator Emeritus
status.
@Trott
Copy link
Member Author

Trott commented May 17, 2019

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3547/

@Trott
Copy link
Member Author

Trott commented May 17, 2019

Landed in f4572cc

@Trott Trott closed this May 17, 2019
Trott added a commit to Trott/io.js that referenced this pull request May 17, 2019
@Trott
meta: move chrisdickinson to Collaborator Emeriti list
f4572cc 
Chris confirmed in email that he could be moved to Collaborator Emeritus
status.

PR-URL: nodejs#27703
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
targos pushed a commit that referenced this pull request May 17, 2019
@Trott @targos
meta: move chrisdickinson to Collaborator Emeriti list
9f9871c 
Chris confirmed in email that he could be moved to Collaborator Emeritus
status.

PR-URL: #27703
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
@BridgeAR BridgeAR mentioned this pull request May 21, 2019
Merged
4 tasks
@Trott Trott deleted the chrisdickinson2emeritus branch January 13, 2022 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@ChALkeR ChALkeR ChALkeR approved these changes

@chrisdickinson chrisdickinson Awaiting requested review from chrisdickinson

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Trott @nodejs-github-bot @ChALkeR @targos @cjihrig @BridgeAR @trivikr