-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tls: add missing 'new' #27614
tls: add missing 'new' #27614
Conversation
Sorry about that :-(. I think this should have a regression test. |
I'm writing a test, I'll post it here. |
@cjihrig how did you find this, by code inspection, or did you actually trigger the bug? I suggest the following (I can PR, or you add to your commit, as you wish).
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change LGTM, but I have a (non-blocking) preference that we add a test here too.
@sam-github I just stumbled on it in the code. I didn't trigger it. I'll pull in your other changes as a separate commit with you as the author. |
ERR_INVALID_OPT_VALUE cannot be constructed without new.
CI: https://ci.nodejs.org/job/node-test-pull-request/23030/ EDIT(cjihrig): CI was yellow. |
Landed in 95c1cb4...ae749e7 |
ERR_INVALID_OPT_VALUE cannot be constructed without new. PR-URL: nodejs#27614 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
PR-URL: nodejs#27614 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
ERR_INVALID_OPT_VALUE cannot be constructed without new. PR-URL: #27614 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
PR-URL: #27614 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
ERR_INVALID_OPT_VALUE
cannot be constructed without new.Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes