Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: update n-api version support matrix #27567

Closed
wants to merge 1 commit into from
Closed

doc: update n-api version support matrix #27567

wants to merge 1 commit into from

Conversation

teams2ua
Copy link
Contributor

@teams2ua teams2ua commented May 4, 2019

As thread safe functions were back-ported to 8.x and released in 8.16

Checklist

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. node-api Issues and PRs related to the Node-API. labels May 4, 2019
@hiroppy
Copy link
Member

hiroppy commented May 4, 2019

Please change the commit message format. See https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines

@teams2ua
doc: update n-api support matrix
7656e33 
As thread safe functions were back-ported to 8.x and released in 8.16
the documentation should be updated as well.
@Trott
Copy link
Member

Trott commented May 5, 2019

Hi, @teams2ua! Welcome and thanks for the pull request! Looks good to me, but let's loop in the N-API experts: ping @nodejs/n-api

@BridgeAR BridgeAR added the review wanted PRs that need reviews. label May 13, 2019
@richardlau richardlau mentioned this pull request May 17, 2019
Closed
3 tasks
mhdawson
mhdawson approved these changes May 17, 2019
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson
Copy link
Member

In case anybody else was going to confirm as well: https://github.com/nodejs/node/blob/v8.x/src/node_version.h shows NAPI_VERSION as 4.

@mhdawson
Copy link
Member

@gabrielschulhof I assume the backport is still in progress for 10.X or we just need a release to come out?

@richardlau
Copy link
Member

@gabrielschulhof I assume the backport is still in progress for 10.X or we just need a release to come out?

@mhdawson I think the backport is in the v10.16.0 proposal -- I asked a question about whether the support matrix needs to be updated in the v10.16.0 release: #27514 (comment)

@richardlau richardlau added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed review wanted PRs that need reviews. labels May 17, 2019
@richardlau
Copy link
Member

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3549/

@mhdawson
Copy link
Member

@richardlau thanks for the update.

@addaleax
Copy link
Member

Landed in 73c16b1

@addaleax addaleax closed this May 26, 2019
addaleax pushed a commit that referenced this pull request May 26, 2019
@teams2ua @addaleax
doc: update n-api support matrix
73c16b1 
As thread safe functions were back-ported to 8.x and released in 8.16
the documentation should be updated as well.

PR-URL: #27567
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request May 28, 2019
@teams2ua @targos
doc: update n-api support matrix
7a7fc4e 
As thread safe functions were back-ported to 8.x and released in 8.16
the documentation should be updated as well.

PR-URL: #27567
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Jun 3, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@richardlau richardlau richardlau approved these changes

@mhdawson mhdawson mhdawson approved these changes

@gabrielschulhof gabrielschulhof Awaiting requested review from gabrielschulhof

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. node-api Issues and PRs related to the Node-API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@teams2ua @hiroppy @Trott @mhdawson @richardlau @addaleax @jasnell @BridgeAR @nodejs-github-bot