test: move dgram invalid host test to internet tests #27565
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves a dgram test from `parallel` to `internet` because it relies on a DNS request. In certain cases, ISPs hijack invalid IETF-reserved invalid names which causes a false negative failure. Fixes: nodejs#27341
Trott
reviewed
May 5, 2019
This test is not parallelized and so we can use the test commons PORT variable. Refs: nodejs#27565 (comment)
This comment has been minimized.
This comment has been minimized.
|
Does anyone have any idea why parallel_test_timers_immediate_queue could be impacted by this change on windows only? Is this a flaky test? |
This comment has been minimized.
This comment has been minimized.
Seems to be a known issue: #24497 |
This comment has been minimized.
This comment has been minimized.
Trott
approved these changes
May 10, 2019
Trott
added
the
author ready
jasnell
approved these changes
May 10, 2019
BridgeAR
approved these changes
May 13, 2019
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
May 13, 2019
This moves a dgram test from `parallel` to `internet` because it relies on a DNS request. In certain cases, ISPs hijack invalid IETF-reserved invalid names which causes a false negative failure. Fixes: nodejs#27341 PR-URL: nodejs#27565 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
May 13, 2019
This test is not parallelized and so we can use the test commons PORT variable. Refs: nodejs#27565 (comment) PR-URL: nodejs#27565 Fixes: nodejs#27341 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
|
Landed in b6bfc19...7294897. Thanks for the contribution! 🎉 |
targos
pushed a commit
that referenced
this pull request
May 14, 2019
This moves a dgram test from `parallel` to `internet` because it relies on a DNS request. In certain cases, ISPs hijack invalid IETF-reserved invalid names which causes a false negative failure. Fixes: #27341 PR-URL: #27565 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
targos
pushed a commit
that referenced
this pull request
May 14, 2019
This test is not parallelized and so we can use the test commons PORT variable. Refs: #27565 (comment) PR-URL: #27565 Fixes: #27341 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves a dgram test from
paralleltointernetbecause it relieson a DNS request.
In certain cases, ISPs hijack invalid IETF-reserved invalid names which
causes a false negative failure.
Fixes: #27341
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes