assert: minor assert improvements

[BridgeAR]

See commit messages for further details.

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• documentation is changed or added
• commit message follows commit guidelines

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/22901/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/22972/

[Trott]

Landed in 7cfcf80...d099f2f

[targos]

This needs to be backported to land on v12.x:

$ out/Release/node --expose-internals test/parallel/test-assert.js
assert.js:540
      throw err;
      ^

AssertionError [ERR_ASSERTION]: Expected values to be strictly deep-equal:
+ actual - expected

  Comparison {
    generatedMessage: true,
+   message: "Expected values to be strictly equal:\n\n[Function] !== ''\n"
-   message: "Expected values to be strictly equal:\n+ actual - expected\n\n+ [Function]\n- ''"
  }
    at testAssertionMessage (/home/mzasso/git/nodejs/v12.x/test/parallel/test-assert.js:267:10)
    at Object.<anonymous> (/home/mzasso/git/nodejs/v12.x/test/parallel/test-assert.js:300:1)
    at Module._compile (internal/modules/cjs/loader.js:759:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:770:10)
    at Module.load (internal/modules/cjs/loader.js:628:32)
    at Function.Module._load (internal/modules/cjs/loader.js:555:12)
    at Function.Module.runMain (internal/modules/cjs/loader.js:822:10)
    at internal/main/run_main_module.js:17:11

[BridgeAR]

@targos I pushed the backport directly onto the staging branch. It was just a very tiny conflict.

--- a/test/parallel/test-assert.js
+++ b/test/parallel/test-assert.js
@@ -291,13 +291,13 @@ testShortAssertionMessage(0, '0');
 testShortAssertionMessage(Symbol(), 'Symbol()');
 testShortAssertionMessage(undefined, 'undefined');
 testShortAssertionMessage(-Infinity, '-Infinity');
+testShortAssertionMessage(function() {}, '[Function]');
 testAssertionMessage([], '[]');
 testAssertionMessage(/a/, '/a/');
 testAssertionMessage(/abc/gim, '/abc/gim');
 testAssertionMessage({}, '{}');
 testAssertionMessage([1, 2, 3], '[\n+   1,\n+   2,\n+   3\n+ ]');
 testAssertionMessage(function f() {}, '[Function: f]');
-testAssertionMessage(function() {}, '[Function]');
 testAssertionMessage(circular, '{\n+   x: [Circular],\n+   y: 1\n+ }');
 testAssertionMessage({ a: undefined, b: null },
                      '{\n+   a: undefined,\n+   b: null\n+ }');