doc: update comment in bootstrap for primordials #27398
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The path has changed
addaleax
approved these changes
Apr 24, 2019
|
Fast track? |
antsmartian
approved these changes
Apr 25, 2019
|
|
Trott
approved these changes
Apr 25, 2019
Trott
added
fast-track
cjihrig
approved these changes
Apr 25, 2019
jasnell
approved these changes
Apr 26, 2019
joyeecheung
approved these changes
Apr 26, 2019
| @@ -17,7 +17,7 @@ | |||
| // Scripts run before this file: | |||
| // - `lib/internal/per_context/setup.js`: to setup the v8::Context with | |||
| // Node.js-specific tweaks - this is also done in vm contexts. | |||
| // - `lib/internal/bootstrap/primordials.js`: to save copies of JavaScript | |||
| // - `lib/internal/per_context/primordials.js`: to save copies of JavaScript | |||
There was a problem hiding this comment.
On a side note there is also lib/internal/per_context/domexception.js now
|
Landed in eca71e5 |
MylesBorins
added a commit
that referenced
this pull request
Apr 26, 2019
The path has changed PR-URL: #27398 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
targos
pushed a commit
that referenced
this pull request
Apr 27, 2019
The path has changed PR-URL: #27398 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The path has changed
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes