Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update V8 to 7.5 #27375

Merged
merged 22 commits into from
Jun 1, 2019
Merged

deps: update V8 to 7.5 #27375

merged 22 commits into from
Jun 1, 2019

Commits on Jun 1, 2019

  1. deps: update V8 to 7.5.288.22

    PR-URL: nodejs#27375
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Ujjwal Sharma <[email protected]>
    Reviewed-By: Refael Ackermann <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Rich Trott <[email protected]>
    refack committed Jun 1, 2019
    Configuration menu
    Copy the full SHA
    ed74896 View commit details
    Browse the repository at this point in the history
  2. build: reset embedder string to "-node.0"

    PR-URL: nodejs#27375
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Ujjwal Sharma <[email protected]>
    Reviewed-By: Refael Ackermann <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Rich Trott <[email protected]>
    refack committed Jun 1, 2019
    Configuration menu
    Copy the full SHA
    d661500 View commit details
    Browse the repository at this point in the history
  3. src: update NODE_MODULE_VERSION to 74

    Major V8 updates are usually API/ABI incompatible with previous
    versions. This commit adapts NODE_MODULE_VERSION for V8 7.5.
    
    Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md
    
    PR-URL: nodejs#27375
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Ujjwal Sharma <[email protected]>
    Reviewed-By: Refael Ackermann <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Rich Trott <[email protected]>
    refack committed Jun 1, 2019
    Configuration menu
    Copy the full SHA
    e3cd79e View commit details
    Browse the repository at this point in the history
  4. build,v8: sync V8 gypfiles with 7.5

    Co-authored-by: Ujjwal Sharma <[email protected]>
    Co-authored-by: Michaël Zasso <[email protected]>
    
    PR-URL: nodejs#27375
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Ujjwal Sharma <[email protected]>
    Reviewed-By: Refael Ackermann <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Rich Trott <[email protected]>
    refack committed Jun 1, 2019
    Configuration menu
    Copy the full SHA
    417c18e View commit details
    Browse the repository at this point in the history
  5. tools,gyp: introduce MSVS 2019

    PR-URL: nodejs#27375
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Ujjwal Sharma <[email protected]>
    Reviewed-By: Refael Ackermann <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Rich Trott <[email protected]>
    refack committed Jun 1, 2019
    Configuration menu
    Copy the full SHA
    317b712 View commit details
    Browse the repository at this point in the history
  6. deps: V8: fix filename manipulation for Windows

    PR-URL: nodejs#27375
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Ujjwal Sharma <[email protected]>
    Reviewed-By: Refael Ackermann <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Rich Trott <[email protected]>
    refack committed Jun 1, 2019
    Configuration menu
    Copy the full SHA
    a74c46b View commit details
    Browse the repository at this point in the history
  7. deps: V8: un-cherry-pick bd019bd

    Original commit message:
    
        [testrunner] delete ancient junit compatible format support
    
        Testrunner has ancient support for JUnit compatible XML output.
    
        This CL removes this old feature.
    
        [email protected],[email protected],[email protected]
        CC=​[email protected]
    
        Bug: v8:8728
        Change-Id: I7e1beb011dbaec3aa1a27398a5c52abdd778eaf0
        Reviewed-on: https://chromium-review.googlesource.com/c/1430065
        Reviewed-by: Jakob Gruber <[email protected]>
        Reviewed-by: Michael Starzinger <[email protected]>
        Commit-Queue: Tamer Tas <[email protected]>
        Cr-Commit-Position: refs/heads/master@{#59045}
    
    Refs: v8/v8@bd019bd
    
    PR-URL: nodejs#26685
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Refael Ackermann <[email protected]>
    refack committed Jun 1, 2019
    Configuration menu
    Copy the full SHA
    e378e7d View commit details
    Browse the repository at this point in the history
  8. deps: V8: silence irrelevant warning

    PR-URL: nodejs#26685
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Refael Ackermann <[email protected]>
    targos authored and refack committed Jun 1, 2019
    Configuration menu
    Copy the full SHA
    115c9be View commit details
    Browse the repository at this point in the history
  9. deps: V8: update postmortem metadata generation script

    Update postmortem metadata constants for V8 7.5 in Node.js.
    
    PR-URL: nodejs#26685
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Refael Ackermann <[email protected]>
    cjihrig authored and refack committed Jun 1, 2019
    Configuration menu
    Copy the full SHA
    0859870 View commit details
    Browse the repository at this point in the history
  10. deps: V8: cherry-pick cca9ae3c9a

    Original commit message:
    
        Remove recursion from NeedsCheckHeapObject.
    
        We use the predicate NeedsCheckHeapObject in the compiler frontend to
        determine whether we can skip introducing CheckHeapObject nodes. But
        this predicate would also walk up the graph in case of Phis, which can
        result in really long compilation times (on the main thread). In the
        report in nodejs#27667, the compiler
        frontend alone took around 4-5mins of main thread time for a single
        function. With this patch the time goes down to 4-5ms.
    
        Bug: v8:9250
        Refs: nodejs#27667
        Change-Id: I231eb780ff04f949fa1669714f9af6ebfbcade05
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1612897
        Reviewed-by: Jaroslav Sevcik <[email protected]>
        Commit-Queue: Benedikt Meurer <[email protected]>
        Cr-Commit-Position: refs/heads/master@{#61503}
    
    Fixes: nodejs#27667
    
    PR-URL: nodejs#27729
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Ruben Bridgewater <[email protected]>
    Reviewed-By: Rich Trott <[email protected]>
    Reviewed-By: Michael Dawson <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    bmeurer authored and refack committed Jun 1, 2019
    Configuration menu
    Copy the full SHA
    cdd4439 View commit details
    Browse the repository at this point in the history
  11. deps: V8: backport f89e555

    Original commit message:
    
        [api] Fix compilation issue with macOS
    
        Fixes the following error caught by the Node.js CI:
    
        ../deps/v8/src/api.cc:8943:10:
          error: no viable conversion from returned value of type
          'unique_ptr<v8::internal::MicrotaskQueue, default_delete<v8::internal::MicrotaskQueue>>'
          to function return type
          'unique_ptr<v8::MicrotaskQueue, default_delete<v8::MicrotaskQueue>>'
    
          return microtask_queue;
                 ^~~~~~~~~~~~~~~
    
        Change-Id: Ic09dab46bb8f87a2b3b59f5836e0883bfe0e9681
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1627533
        Commit-Queue: Michaël Zasso <[email protected]>
        Commit-Queue: Yang Guo <[email protected]>
        Reviewed-by: Yang Guo <[email protected]>
        Cr-Commit-Position: refs/heads/master@{#61789}
    
    Refs: v8/v8@f89e555
    
    PR-URL: nodejs#27375
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Ujjwal Sharma <[email protected]>
    Reviewed-By: Refael Ackermann <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Rich Trott <[email protected]>
    targos authored and refack committed Jun 1, 2019
    Configuration menu
    Copy the full SHA
    4badd3e View commit details
    Browse the repository at this point in the history
  12. deps: V8: patch register-arm64.h

    Fixes a compilation issue on some platforms
    
    PR-URL: nodejs#27375
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Ujjwal Sharma <[email protected]>
    Reviewed-By: Refael Ackermann <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Rich Trott <[email protected]>
    refack committed Jun 1, 2019
    Configuration menu
    Copy the full SHA
    9457fab View commit details
    Browse the repository at this point in the history
  13. deps: V8: forward declaration of Rtl*FunctionTable

    This should be semver-patch since actual invocation is version
    conditional.
    
    PR-URL: nodejs#27375
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Ujjwal Sharma <[email protected]>
    Reviewed-By: Refael Ackermann <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Rich Trott <[email protected]>
    refack committed Jun 1, 2019
    Configuration menu
    Copy the full SHA
    a6e7d21 View commit details
    Browse the repository at this point in the history
  14. deps: V8: use ATOMIC_VAR_INIT instead of std::atomic_init

    `std::atomic_init<size_t>` is not implemented in all platforms.
    
    * pragma to ignore `-Wbraced-scalar-init`
    
    PR-URL: nodejs#27375
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Ujjwal Sharma <[email protected]>
    Reviewed-By: Refael Ackermann <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Rich Trott <[email protected]>
    refack committed Jun 1, 2019
    Configuration menu
    Copy the full SHA
    c81bb22 View commit details
    Browse the repository at this point in the history
  15. deps: V8: template explicit instantiation for GCC-8

    Fails to link for missing:
    void JSObject::ApplyAttributesToDictionary<NumberDictionary>(...)
    
    PR-URL: nodejs#27375
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Ujjwal Sharma <[email protected]>
    Reviewed-By: Refael Ackermann <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Rich Trott <[email protected]>
    refack committed Jun 1, 2019
    Configuration menu
    Copy the full SHA
    0df8f53 View commit details
    Browse the repository at this point in the history
  16. deps: V8: workaround for MSVC 14.20 optimizer bug

    Refs: https://developercommunity.visualstudio.com/content/problem/512352/compiler-doesnt-finish-142027508.html
    
    PR-URL: nodejs#27375
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Ujjwal Sharma <[email protected]>
    Reviewed-By: Refael Ackermann <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Rich Trott <[email protected]>
    refack committed Jun 1, 2019
    Configuration menu
    Copy the full SHA
    6797610 View commit details
    Browse the repository at this point in the history
  17. deps: V8: fix BUILDING_V8_SHARED issues

    PR-URL: nodejs#27375
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Ujjwal Sharma <[email protected]>
    Reviewed-By: Refael Ackermann <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Rich Trott <[email protected]>
    refack committed Jun 1, 2019
    Configuration menu
    Copy the full SHA
    ad40a03 View commit details
    Browse the repository at this point in the history
  18. deps: V8: backport 3a75c1f

    Original commit message:
    
        Fixing a possible freeze on abort with 'v8_win64_unwinding_info'
    
        Win64 unwind data can specify a language-specific handler function which is
        called as part of the search for an exception handler, as described in
        https://docs.microsoft.com/en-us/cpp/build/exception-handling-x64?view=vs-2019.
        This is used for example by Crashpad to register its own exception handler for
        exceptions in V8-generated code.
        There is a problem in the code that may cause a freeze on abort: in file
        \deps\v8\src\unwinding-info-win64.cc in function CRASH_HANDLER_FUNCTION_NAME the
        line:
            return EXCEPTION_CONTINUE_SEARCH;
        should be
            return ExceptionContinueSearch;
    
        These constants are both used in the context of Win32 exception handlers, but
        they have different semantics and unfortunately different values:
        EXCEPTION_CONTINUE_SEARCH (=0) should be returned by an exception filter
        while a language-specific handler should return an EXCEPTION_DISPOSITION value,
        and more precisely ExceptionContinueSearch (=1) in this case.
    
        Bug: v8:9295
        Change-Id: I1a3aaabf357e52a909611814f1ea013cf652ae06
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1629795
        Reviewed-by: Jakob Kummerow <[email protected]>
        Commit-Queue: Paolo Severini <[email protected]>
        Cr-Commit-Position: refs/heads/master@{#61867}
    
    Refs: v8/v8@3a75c1f
    
    PR-URL: nodejs#27375
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Ujjwal Sharma <[email protected]>
    Reviewed-By: Refael Ackermann <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Rich Trott <[email protected]>
    refack committed Jun 1, 2019
    Configuration menu
    Copy the full SHA
    951318f View commit details
    Browse the repository at this point in the history
  19. deps: bump minimum icu version to 64

    Bump minimum version of ICU needed to build node to 64.
    
    Refs: v8/v8@ccbe3d0
    
    PR-URL: nodejs#27375
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Ujjwal Sharma <[email protected]>
    Reviewed-By: Refael Ackermann <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Rich Trott <[email protected]>
    targos authored and refack committed Jun 1, 2019
    Configuration menu
    Copy the full SHA
    f73d5c2 View commit details
    Browse the repository at this point in the history
  20. test: drain platform before unregistering isolate

    PR-URL: nodejs#27375
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Ujjwal Sharma <[email protected]>
    Reviewed-By: Refael Ackermann <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Rich Trott <[email protected]>
    refack committed Jun 1, 2019
    Configuration menu
    Copy the full SHA
    abfc8ae View commit details
    Browse the repository at this point in the history
  21. lib: no need to strip BOM or shebang for scripts

    PR-URL: nodejs#27375
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Ujjwal Sharma <[email protected]>
    Reviewed-By: Refael Ackermann <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Rich Trott <[email protected]>
    refack committed Jun 1, 2019
    Configuration menu
    Copy the full SHA
    702331b View commit details
    Browse the repository at this point in the history
  22. test: fail test-worker-prof on internal timeout

    PR-URL: nodejs#27375
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Ujjwal Sharma <[email protected]>
    Reviewed-By: Refael Ackermann <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Rich Trott <[email protected]>
    refack committed Jun 1, 2019
    Configuration menu
    Copy the full SHA
    2983eac View commit details
    Browse the repository at this point in the history