Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: simplify GOVERNANCE.md text #27354

Closed
wants to merge 1 commit into from
Closed

Conversation

Trott
Copy link
Member

@Trott Trott commented Apr 23, 2019

Some final simplifications for the last few paragraphs of GOVERNANCE.md.
Split a long sentence into shorter sentences. Use more consistent text.
(A nomination passes rather than "is accepted" to match language in the
previous section.)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

Some final simplifications for the last few paragraphs of GOVERNANCE.md.
Split a long sentence into shorter sentences. Use more consistent text.
(A nomination passes rather than "is accepted" to match language in the
previous section.)
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Apr 23, 2019
@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 23, 2019
@Trott
Copy link
Member Author

Trott commented Apr 26, 2019

Landed in 0a121d3

@Trott Trott closed this Apr 26, 2019
Trott added a commit to Trott/io.js that referenced this pull request Apr 26, 2019
Some final simplifications for the last few paragraphs of GOVERNANCE.md.
Split a long sentence into shorter sentences. Use more consistent text.
(A nomination passes rather than "is accepted" to match language in the
previous section.)

PR-URL: nodejs#27354
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
targos pushed a commit that referenced this pull request Apr 27, 2019
Some final simplifications for the last few paragraphs of GOVERNANCE.md.
Split a long sentence into shorter sentences. Use more consistent text.
(A nomination passes rather than "is accepted" to match language in the
previous section.)

PR-URL: #27354
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@targos targos mentioned this pull request Apr 27, 2019
@Trott Trott deleted the final-gov-edits branch January 13, 2022 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants