-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src: fix performance-faster-string-find in node_report.cc #27262
Closed
gengjiawen
wants to merge
1
commit into
nodejs:master
from
gengjiawen:performance-faster-string-find
Closed
src: fix performance-faster-string-find in node_report.cc #27262
gengjiawen
wants to merge
1
commit into
nodejs:master
from
gengjiawen:performance-faster-string-find
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
Issues and PRs that require attention from people who are familiar with C++.
report
Issues and PRs related to process.report.
labels
Apr 16, 2019
richardlau
approved these changes
Apr 16, 2019
BridgeAR
approved these changes
Apr 16, 2019
BridgeAR
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Apr 16, 2019
addaleax
approved these changes
Apr 16, 2019
mhdawson
approved these changes
Apr 18, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ZYSzys
approved these changes
Apr 19, 2019
Landed in 7581910 🎉 |
ZYSzys
pushed a commit
that referenced
this pull request
Apr 19, 2019
PR-URL: #27262 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]>
This was referenced Apr 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
c++
Issues and PRs that require attention from people who are familiar with C++.
report
Issues and PRs related to process.report.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://ci.nodejs.org/job/node-clang-tidy/7/console.
cc @richardlau @refack
Not sure why not caught by my clang-tidy, which version is Jenkins using ?
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes