Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: enable V8's WASM trap handlers #27246

Merged
merged 1 commit into from
May 16, 2019
Merged

src: enable V8's WASM trap handlers #27246

merged 1 commit into from
May 16, 2019

Commits on May 16, 2019

  1. src: enable V8's WASM trap handlers 

    This uses SIGSEGV handlers to catch WASM out of bound (OOB) memory
accesses instead of inserting OOB checks inline, resulting in a 25%-30%
speed increase.

Note that installing a custom SIGSEGV handler will break this, resulting
in potentially scary behaviour.

Refs: nodejs#14927

PR-URL: nodejs#27246
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
    @devsnek
    devsnek committed May 16, 2019
    Configuration menu
    Copy the full SHA
    70c7686 View commit details
    Browse the repository at this point in the history