Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: revise TSC Meetings material in GOVERNANCE.md #27204

Closed
wants to merge 2 commits into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Apr 12, 2019

Make the TSC Meetings section in GOVERNANCE.md simpler and shorter.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

Make the TSC Meetings section in GOVERNANCE.md simpler and shorter.
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Apr 12, 2019
@Trott
Copy link
Member Author

Trott commented Apr 12, 2019

R: @nodejs/tsc

GOVERNANCE.md Outdated
Items are added to the TSC agenda which are considered contentious or
are modifications of governance, contribution policy, TSC membership,
or release process.
The TSC agenda consists only of issues that are at an impasse. The intention of
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change now excludes things like #26186 which was an example of modifications of TSC membership. Given that voting for approving TSC members happens in the TSC meetings it kind of makes sense for those issues to be added to the agenda.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that voting for approving TSC members happens in the TSC meetings it kind of makes sense for those issues to be added to the agenda.

I'm OK with adding it back if that's the consensus, but IIUC, the only reason that stuff was in the agenda was because this doc (and maybe others?) said or implied that it had to happen in a meeting. I suspect current TSC consensus would be that there's no reason for the vote to have to happen in a meeting. It can (and, IMO, should) happen in a GitHub issue. The new member can be announced/celebrated during the announcements portion of the meeting.

Voting during meetings is suboptimal and should be avoided IMO because it means only people who can attend that particular meeting get to vote. For membership votes (and some others), we subverted that by gathering votes ahead of time. But the gathering of votes ahead of time, especially for a non-controversial nomination, would seem to argue that the vote doesn't need to happen in the meeting.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll defer to @nodejs/tsc if this covers everything that should be on the agenda. Looking at the recent agenda I see tracking issues and things related to the merger of the foundations which all appear to be for informational/discussion purposes and are not things at an impasse.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think its quite right to say the agenda only consists of things that are at impasse. An update for the board and the strategic initiatives don't fall under that.

Copy link
Member Author

@Trott Trott Apr 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tracking issues are things I have argued should be part of the meeting template (like Announcements) and not individual agenda items. If this lands, I'll open a PR against the meeting agenda generator to make that so.

IMO, the informational things are OK if they are not getting sufficient attention. Perhaps rather than "impasse", it should say something about being stalled due to disagreement or lack of attention? Or maybe "impasse" covers it sufficiently, if somewhat imprecisely?

Copy link
Member Author

@Trott Trott Apr 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@richardlau @mhdawson I changed the text to be less rigid: "The TSC agenda includes issues that are at an impasse." That way, it doesn't exclude anything, but also doesn't list out every type of thing that can end up on the agenda. Let me know if that doesn't sufficiently address your concerns. Thanks!

Trott added a commit to Trott/io.js that referenced this pull request Apr 15, 2019
Make the TSC Meetings section in GOVERNANCE.md simpler and shorter.

PR-URL: nodejs#27204
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@Trott
Copy link
Member Author

Trott commented Apr 15, 2019

Landed in 82e6c33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants