-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: optimize total Travis run time #27182
Conversation
1d940ba
to
f3b8644
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Ab)using the ccache to transfer binaries between compile and test jobs ✔️💡.
Maybe update the OP? Stages haven't been eliminated. |
9d4dae1
to
92eb382
Compare
Travis run now covers addons as well. minimal time approx 4(compile) + 5.5(test) minutes. |
544a2ff
to
2879a5f
Compare
@nodejs/testing @nodejs/build-files PTAL |
cfeee14
to
d3266fb
Compare
🤔 https://travis-ci.com/nodejs/node/jobs/192591927 ran 2500 tests. |
Ah it's Lines 502 to 506 in 25df3c1
Lines 472 to 474 in 25df3c1
|
* skip compilation by using cache * split testing into two jobs * DRY with YAML anchors PR-URL: nodejs#27182 Refs: nodejs#27158 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]>
d3266fb
to
8cf3af1
Compare
Refs: #27158
Eliminates the stages; they are unnecessary for a typical CI run, and extend the run time by at least 3.5 minutes.Instead of eliminating the compile stage it now caches the binary so the test stage doesn't need to bootstrap the compiler and doesn't need to recompile.
/CC @nodejs/testing @nodejs/build-files @nodejs/python
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes