src: make a Environment-independent proxy class for NativeModuleLoader #27160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
2 tasks
addaleax
approved these changes
Apr 9, 2019
|
@nodejs/process @nodejs/build-files This needs one more review to land - I hope to land this soon so that #27135 can be unblocked. |
richardlau
approved these changes
Apr 12, 2019
This patch splits `NativeModuleLoader` into two parts - a singleton that only relies on v8 and `node::Mutex` and a proxy class for the singleton (`NativeModuleEnv`) that provides limited access to the singleton as well as C++ bindings for the Node.js binary. `NativeModuleLoader` is then no longer aware of `Environment`.
joyeecheung
force-pushed
the
split-loader
branch
from
d93325e
to
162e91c
Compare
joyeecheung
added
author ready
|
Landed in dfd7e99 |
joyeecheung
added a commit
to joyeecheung/node
that referenced
this pull request
Apr 13, 2019
This patch splits `NativeModuleLoader` into two parts - a singleton that only relies on v8 and `node::Mutex` and a proxy class for the singleton (`NativeModuleEnv`) that provides limited access to the singleton as well as C++ bindings for the Node.js binary. `NativeModuleLoader` is then no longer aware of `Environment`. PR-URL: nodejs#27160 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]>
This was referenced Apr 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch splits
NativeModuleLoaderinto two parts - a singletonthat only relies on v8 and
node::Mutexand a proxy class forthe singleton (
NativeModuleEnv) that provides limited access tothe singleton as well as C++ bindings for the Node.js binary.
NativeModuleLoaderis then no longer aware ofEnvironment.This is split out of #27135
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes