Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: move DEP0021 to end of life #27127

Merged
merged 1 commit into from
Apr 10, 2019
Merged

lib: move DEP0021 to end of life #27127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions doc/api/deprecations.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -483,6 +483,9 @@ The [`Server.connections`][] property is deprecated. Please use the
### DEP0021: Server.listenFD
<!-- YAML
changes:
- version: REPLACEME
pr-url: https://github.com/nodejs/node/pull/27127
description: End-of-Life.
- version:
- v4.8.6
- v6.12.0
Expand All @@ -493,9 +496,9 @@ changes:
description: Runtime deprecation.
-->

Type: Runtime
Type: End-of-Life

The `Server.listenFD()` method is deprecated. Please use
The `Server.listenFD()` method was deprecated and removed. Please use
[`Server.listen({fd: <number>})`][] instead.

<a id="DEP0022"></a>
Expand Down
6 changes: 0 additions & 6 deletions lib/net.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1590,12 +1590,6 @@ Object.defineProperty(Socket.prototype, '_handle', {
set(v) { return this[kHandle] = v; }
});


Server.prototype.listenFD = deprecate(function(fd, type) {
return this.listen({ fd: fd });
}, 'Server.listenFD is deprecated. Use Server.listen({fd: <number>}) instead.',
'DEP0021');

Server.prototype._setupWorker = function(socketList) {
this._usingWorkers = true;
this._workers.push(socketList);
Expand Down