Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix test-benchmark-module #27094

Closed
wants to merge 1 commit into from
Closed

test: fix test-benchmark-module #27094

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Apr 4, 2019

A recent commit broke test-benchmark-module. This fixes it.

Culprit is #26970.

Collaborators, please 👍 here if you approve fast-tracking.

@BridgeAR @nodejs/testing

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@Trott
test: fix test-benchmark-module
ab04470 
A recent commit broke test-benchmark-module. This fixes it.

Culprit is nodejs#26970.
@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 4, 2019
@nodejs-github-bot
Copy link
Collaborator

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3173

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Apr 4, 2019
@Trott
Copy link
Member Author

Trott commented Apr 4, 2019 •
edited
Loading

Benchmark test CI: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/5972/ ✅

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 5, 2019
Trott added a commit to Trott/io.js that referenced this pull request Apr 5, 2019
@Trott
test: fix test-benchmark-module
c86883c 
A recent commit broke test-benchmark-module. This fixes it.

PR-URL: nodejs#27094
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Bryan English <[email protected]>
@Trott
Copy link
Member Author

Trott commented Apr 5, 2019

Landed in c86883c

@Trott Trott closed this Apr 5, 2019
This was referenced Apr 23, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@Trott Trott deleted the fix-module-benchmark branch January 13, 2022 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danbev danbev danbev approved these changes

@bengl bengl bengl approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Trott @nodejs-github-bot @bengl @danbev