-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: patch V8 to 7.4.288.18 #27066
Merged
Merged
deps: patch V8 to 7.4.288.18 #27066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
v8 engine
Issues and PRs related to the V8 dependency.
label
Apr 3, 2019
targos
added
dont-land-on-v10.x
and removed
v8 engine
Issues and PRs related to the V8 dependency.
labels
Apr 3, 2019
cjihrig
approved these changes
Apr 3, 2019
Updated to 7.4.288.18. I need at least one more approval. |
refack
approved these changes
Apr 5, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RSLGTM
Refs: v8/v8@7.4.288.13...7.4.288.17 PR-URL: nodejs#27066 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
Refs: v8/v8@7.4.288.17...7.4.288.18 PR-URL: nodejs#27066 Refs: v8/v8@7.4.288.13...7.4.288.17 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
Landed in c86883c...135b79a31d51939d46b68eaea5249e28c7f67757 |
This was referenced Apr 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: v8/v8@7.4.288.13...7.4.288.17
@nodejs/v8-update