-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build,meta: tweak Travis config #26969
Conversation
@refack Sadly, an error occurred when I tried to trigger a build. :( |
Reminder that if you're bumping the gcc version you may have to land in more than one commit to populate the ccache as I had to when we moved to gcc 6 (#26720 (comment)). |
Mostly wanted to see if this builds faster. Since we might get in the same mess when we land V8 or change BTW: https://docs.travis-ci.com/user/caching/#pull-request-builds-and-caches cache lookup and storage is fairly nuanced. |
Travis builds are now timing out, which I suspect might be the recent V8 update 😢. |
Ok first Travis job passed, so I cleared the cache and restarted. |
This is ready for review. /CC @nodejs/build-files @nodejs/testing |
.travis.yml
Outdated
script: | ||
- PARALLEL_ARGS='--flaky-tests=skip' make -j1 test | ||
- TEST_CI_ARGS="--flaky-tests=skip --report default" make -j1 V= test-ci |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the tap format used by test-ci
Travis truncates the log in the web UI. e.g. https://travis-ci.com/nodejs/node/jobs/188985249 so you need to click through to the raw logs to see the full test results.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some grepping to get it down to ~6K lines
Ping @nodejs/build-files @nodejs/testing |
* Add `lint-py-build` to get `lint-ci` to lint python * Add compile V8 job * Make compilation verbose * Test with `test-ci` PR-URL: nodejs#26969 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
* Add `lint-py-build` to get `lint-ci` to lint python * Add compile V8 job * Make compilation verbose * Test with `test-ci` PR-URL: #26969 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
* Add `lint-py-build` to get `lint-ci` to lint python * Add compile V8 job * Make compilation verbose * Test with `test-ci` PR-URL: #26969 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Signed-off-by: Beth Griggs <[email protected]>
* Add `lint-py-build` to get `lint-ci` to lint python * Add compile V8 job * Make compilation verbose * Test with `test-ci` PR-URL: #26969 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Signed-off-by: Beth Griggs <[email protected]>
* Add `lint-py-build` to get `lint-ci` to lint python * Add compile V8 job * Make compilation verbose * Test with `test-ci` PR-URL: #26969 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Signed-off-by: Beth Griggs <[email protected]>
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes