modules: fix repl require calling the same file again #26928
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nodejs/modules PTAL |
guybedford
reviewed
Mar 27, 2019
This makes sure multiple require calls will not fail in case a file was created after the first attempt.
BridgeAR
force-pushed
the
fix-repl-require
branch
from
734f43f
to
c3aba6c
Compare
|
Rebased due to conflicts. @nodejs/modules PTAL |
|
@nodejs/modules this could use some reviews. It fixes a minor regression. |
guybedford
approved these changes
Apr 1, 2019
BridgeAR
added
the
author ready
This was referenced Apr 2, 2019
|
This could use another review. |
jkrems
approved these changes
Apr 3, 2019
BridgeAR
added a commit
to BridgeAR/node
that referenced
this pull request
Apr 3, 2019
This makes sure multiple require calls will not fail in case a file was created after the first attempt. PR-URL: nodejs#26928 Fixes: nodejs#26926 Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: Jan Krems <[email protected]>
|
Landed in 8a6dcd0 🎉 |
BethGriggs
pushed a commit
that referenced
this pull request
Apr 4, 2019
This makes sure multiple require calls will not fail in case a file was created after the first attempt. PR-URL: #26928 Fixes: #26926 Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: Jan Krems <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 9, 2019
This makes sure multiple require calls will not fail in case a file was created after the first attempt. PR-URL: #26928 Fixes: #26926 Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: Jan Krems <[email protected]>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Apr 10, 2019
This makes sure multiple require calls will not fail in case a file was created after the first attempt. PR-URL: #26928 Fixes: #26926 Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: Jan Krems <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sure multiple require calls will not fail in case a file
was created after the first attempt.
Fixes: #26926
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes