Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: elevate v8::Task namespace #26909

Closed
wants to merge 1 commit into from
Closed

src: elevate v8::Task namespace #26909

wants to merge 1 commit into from

Conversation

juanarbol
Copy link
Member

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Mar 25, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/21894/

@juanarbol
Copy link
Member Author

I've made other contributions doing the same, does anyone here has documentation about how C++ bindings works, how C++ API is connected with JS API's?, or if could anyone explain me that would be awesome!

I'd love to do more "valuable" contributions in C++

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 26, 2019
@targos
Copy link
Member

targos commented Mar 30, 2019

Landed in a3cf96c

@targos targos closed this Mar 30, 2019
targos pushed a commit that referenced this pull request Mar 30, 2019
@juanarbol @targos
src: elevate v8::Task namespace
a3cf96c 
PR-URL: #26909
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@targos
Copy link
Member

targos commented Mar 30, 2019

I've made other contributions doing the same, does anyone here has documentation about how C++ bindings works, how C++ API is connected with JS API's?, or if could anyone explain me that would be awesome!

@addaleax is probably one of the best people to ask this.

BethGriggs pushed a commit that referenced this pull request Apr 5, 2019
@juanarbol @BethGriggs
src: elevate v8::Task namespace
a551c32 
PR-URL: #26909
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
BethGriggs pushed a commit that referenced this pull request Apr 9, 2019
@juanarbol @BethGriggs
src: elevate v8::Task namespace
8069494 
PR-URL: #26909
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Signed-off-by: Beth Griggs <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Apr 9, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Apr 10, 2019
@juanarbol @BethGriggs
src: elevate v8::Task namespace
a318cbc 
PR-URL: #26909
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Signed-off-by: Beth Griggs <[email protected]>
@juanarbol juanarbol deleted the cc-elevate-isolate branch January 19, 2021 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@juanarbol @nodejs-github-bot @targos @cjihrig @BridgeAR