timers: move priority_queue to internal/timers/

[ZYSzys]

The priority_queue.js is only used in timers module, so maybe it's more reasonable to move it into internal/timers/ specifically ?

(I've used git mv command so I think it wouldn't hurt when git blame priority_queue.js)

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• commit message follows commit guidelines

[nodejs-github-bot]

@ZYSzys build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/3019/pipeline

[mscdex]

Perhaps we should move this benchmark file to the timers directory now?

[Trott]

If you do that (and I think it's a fine idea), be sure to run test/benchmark/test-benchmark-timers to make sure the move doesn't break that test file. (If it does break it, it should be easy to fix, but you may have to know something about how the benchmark tests work. Happy to help with that, although I'm guessing you'll figure it out if you aren't familiar with the benchmark tests already.)

[Trott]

^^^^ You'll want to run that test locally because the benchmark tests don't run in node-test-pull-request. (But they do run in node-daily-master so if it breaks, we'll find out, but not until after the code lands!)

[ZYSzys]

Yep👍.

And I've run python tools/test.py -J --mode=release benchmark/test-benchmark-timers and this benchmark test passed, so I think it should be fine :)

[joyeecheung]

By the way you can use https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/ to run this in the CI for this PR (use benchmark in CI_JS_SUITES)

[ZYSzys]

Cool, thank you.

[lpinca]

It is only used in timers now but it could be also used for something else in future no?

[joyeecheung]

Benchmark CI (the testing one): https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/5617/

[ZYSzys]

It is only used in timers now but it could be also used for something else in future no?

AFAIK, priority_queue.js was added in #20555 originally for improving timers performance specially.

It's a little hard for me to figure out other modules where priority_queue.js can be used in the future.

Maybe /cc @nodejs/timers

[Fishrock123]

I do not see what purpose this PR is... Does this actually matter?

[ZYSzys]

Maybe slightly improve the tidiness of our lib/internal/ files' structure, easier to know that priority_queue is used in timers module ?

[sam-github]

Putting timers code in internal/timers/ seems reasonable to me.

[BridgeAR]

I personally would keep it where it is due to possibly reusing it elsewhere at some point.

[apapirovski]

It’s a generic implementation of a binary heap in JS. I see no reason to move it. Does this actually improve anything?

[ZYSzys]

@apapirovski

Maybe slightly improve the tidiness of our lib/internal/ files' structure, easier to know that priority_queue is used in timers module ?

There was no any other affect,

and I'm also willng to close this since majority wants keep it is as original.

Still thanks all.