Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove discord community #26830

Closed
wants to merge 1 commit into from
Closed

Remove discord community #26830

wants to merge 1 commit into from

Conversation

aymen94
Copy link
Member

@aymen94 aymen94 commented Mar 20, 2019 •
edited
Loading

I think it is better to remove it since it is no longer an active community.

Official(?) discord abandoned : #25494

The last Message on discord is dated 14/01/2019

@nodejs/collaborators
@nodejs/tsc

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Mar 20, 2019
Fishrock123
Fishrock123 approved these changes Mar 21, 2019
View reviewed changes
Copy link
Contributor

@Fishrock123 Fishrock123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is locked. No point in linking it.

@vsemozhetbyt vsemozhetbyt added the meta Issues and PRs related to the general management of the project. label Mar 21, 2019
Trott
Trott approved these changes Mar 21, 2019
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I thought we had already removed it everywhere! Whoops!

@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 21, 2019
@Trott
Copy link
Member

Trott commented Mar 21, 2019

This seems fast-trackable to me. If you are a Collaborator and agree, please 👍 here to fast-track.

@Trott
Copy link
Member

Trott commented Mar 21, 2019

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/2996/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 21, 2019
@Trott
Copy link
Member

Trott commented Mar 21, 2019

Landed in 4643fd7

@Trott Trott closed this Mar 21, 2019
Trott pushed a commit to Trott/io.js that referenced this pull request Mar 21, 2019
@aymen94 @Trott
doc: remove discord community
4643fd7 
PR-URL: nodejs#26830
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
targos pushed a commit to targos/node that referenced this pull request Mar 27, 2019
@aymen94 @targos
doc: remove discord community
d864091 
PR-URL: nodejs#26830
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
targos pushed a commit that referenced this pull request Mar 27, 2019
@aymen94 @targos
doc: remove discord community
560ff91 
PR-URL: #26830
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
@targos targos mentioned this pull request Mar 27, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Apr 17, 2019
@aymen94 @BethGriggs
doc: remove discord community
d7cdf8c 
PR-URL: #26830
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
@BethGriggs BethGriggs mentioned this pull request May 1, 2019
Merged
MylesBorins pushed a commit that referenced this pull request May 16, 2019
@aymen94 @MylesBorins
doc: remove discord community
889d68c 
PR-URL: #26830
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
This was referenced May 29, 2019
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZYSzys ZYSzys ZYSzys approved these changes

@devsnek devsnek devsnek approved these changes

@codebytere codebytere codebytere approved these changes

@antsmartian antsmartian antsmartian approved these changes

@Fishrock123 Fishrock123 Fishrock123 approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@aymen94 @Trott @Fishrock123 @antsmartian @codebytere @devsnek @ZYSzys @vsemozhetbyt @nodejs-github-bot