Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: remove unused variables #26590

Closed
wants to merge 1 commit into from
Closed

src: remove unused variables #26590

wants to merge 1 commit into from

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Mar 11, 2019

These were causing compilation warnings.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@cjihrig
src: remove unused variables
a0e134d 
These were causing compilation warnings.
@nodejs-github-bot
Copy link
Collaborator

@cjihrig build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2863/pipeline

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Mar 11, 2019
@cjihrig
Copy link
Contributor Author

cjihrig commented Mar 11, 2019

I wouldn't be opposed to fast tracking this. 👍 this if you agree?

@refack
Copy link
Contributor

refack commented Mar 11, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/21427/

@refack refack added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 11, 2019
@cjihrig
Copy link
Contributor Author

cjihrig commented Mar 11, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/21428/

@cjihrig
Copy link
Contributor Author

cjihrig commented Mar 11, 2019

I just cancelled my CI run :-D

@refack
Copy link
Contributor

refack commented Mar 11, 2019 •
edited by cjihrig
Loading

I just cancelled my CI run :-D

Me too, so https://ci.nodejs.org/job/node-test-pull-request/21429/

EDIT(cjihrig): Green resume CI: https://ci.nodejs.org/job/node-test-pull-request/21448/

@danbev
Copy link
Contributor

danbev commented Mar 12, 2019

Landed in 3753f9c.

@danbev danbev closed this Mar 12, 2019
danbev pushed a commit that referenced this pull request Mar 12, 2019
@cjihrig @danbev
src: remove unused variables
3753f9c 
These were causing compilation warnings.

PR-URL: #26590
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
@cjihrig cjihrig deleted the warning branch March 12, 2019 11:53
BridgeAR pushed a commit that referenced this pull request Mar 13, 2019
@cjihrig @BridgeAR
src: remove unused variables
0ed2a01 
These were causing compilation warnings.

PR-URL: #26590
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Mar 13, 2019
Merged
BridgeAR pushed a commit that referenced this pull request Mar 14, 2019
@cjihrig @BridgeAR
src: remove unused variables
9768ec4 
These were causing compilation warnings.

PR-URL: #26590
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@refack refack refack approved these changes

@hiroppy hiroppy hiroppy approved these changes

@richardlau richardlau richardlau approved these changes

@himself65 himself65 himself65 approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@cjihrig @nodejs-github-bot @refack @danbev @hiroppy @richardlau @himself65