Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs: allow int64 offset in fs.read/readSync/write/writeSync #26572

Closed
wants to merge 4 commits into from
Closed

fs: allow int64 offset in fs.read/readSync/write/writeSync #26572

wants to merge 4 commits into from

Commits on Aug 12, 2019

  1. lib: rename validateInteger to validateSafeInteger

    @zbjornson
    zbjornson committed Aug 12, 2019
    Configuration menu
    Copy the full SHA
    75b6ec9 View commit details
    Browse the repository at this point in the history

  2. fs: allow int64 offset in fs.read/readSync/fd.read 

    Since v10.10.0, 'buf' can be any DataView, meaning the largest
byteLength can be Float64Array.BYTES_PER_ELEMENT * kMaxLength =
17,179,869,176.

'offset' can now be up to 2**53 - 1. This makes it possible to tile
reads into a large buffer.

Breaking: now throws if read offset is not a safe int, is null or
is undefined.

Fixes nodejs#26563
    @zbjornson
    zbjornson committed Aug 12, 2019
    Configuration menu
    Copy the full SHA
    a888eca View commit details
    Browse the repository at this point in the history

  3. fs: use IsSafeJsInt instead of IsNumber for ftruncate

    @zbjornson
    zbjornson committed Aug 12, 2019
    Configuration menu
    Copy the full SHA
    6789e96 View commit details
    Browse the repository at this point in the history

  4. fs: allow int64 offset in fs.write/writeSync/fd.write 

    Ref nodejs#26563
    @zbjornson
    zbjornson committed Aug 12, 2019
    Configuration menu
    Copy the full SHA
    8f545bf View commit details
    Browse the repository at this point in the history