Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: merge debug-only SealHandleScopes #26459

Closed
wants to merge 1 commit into from
Closed

src: merge debug-only SealHandleScopes #26459

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

@addaleax addaleax commented Mar 5, 2019

Instead of repeating the same #ifdef DEBUG + SealHandleScope
pattern over and over, create an utility that does this for us.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

A debugging seal

@nodejs-github-bot
Copy link
Collaborator

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2774/pipeline

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Mar 5, 2019
@addaleax
src: merge debug-only SealHandleScopes
8f3fe6b 
Instead of repeating the same `#ifdef DEBUG` + `SealHandleScope`
pattern over and over, create an utility that does this for us.
bnoordhuis
bnoordhuis approved these changes Mar 5, 2019
View reviewed changes
Copy link
Member

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually thought of suggesting this in one of your other PRs but then I thought "nah, I'll fix that myself sometime." It's nice that I won't have to now. :-)

src/node_internals.h Outdated Show resolved Hide resolved
@addaleax
Copy link
Member Author

addaleax commented Mar 5, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/21228/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 5, 2019
@addaleax
Copy link
Member Author

addaleax commented Mar 7, 2019

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/21298/

@BridgeAR
Copy link
Member

BridgeAR commented Mar 8, 2019

Landed in 2699f8c 🎉

@BridgeAR BridgeAR closed this Mar 8, 2019
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 8, 2019
@addaleax @BridgeAR
src: merge debug-only SealHandleScopes
2699f8c 
Instead of repeating the same `#ifdef DEBUG` + `SealHandleScope`
pattern over and over, create an utility that does this for us.

PR-URL: nodejs#26459
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
BridgeAR pushed a commit that referenced this pull request Mar 13, 2019
@addaleax @BridgeAR
src: merge debug-only SealHandleScopes
28b500f 
Instead of repeating the same `#ifdef DEBUG` + `SealHandleScope`
pattern over and over, create an utility that does this for us.

PR-URL: #26459
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Mar 13, 2019
Merged
BridgeAR pushed a commit that referenced this pull request Mar 14, 2019
@addaleax @BridgeAR
src: merge debug-only SealHandleScopes
edc4af0 
Instead of repeating the same `#ifdef DEBUG` + `SealHandleScope`
pattern over and over, create an utility that does this for us.

PR-URL: #26459
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes

@cjihrig cjihrig cjihrig approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@addaleax @nodejs-github-bot @BridgeAR @bnoordhuis @cjihrig @joyeecheung