Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: update babel-eslint to 10.0.1 #26347

Closed
wants to merge 1 commit into from
Closed

Conversation

Trott
Copy link
Member

@Trott Trott commented Feb 28, 2019

Update babel-eslint to 10.0.1.

The version we ship with currently has some minor vulnerabilities in lodash in its dependency tree. This won't affect end users, of course, but it does generate noise in some auditing tools, and we should set a good example in the source code and not use versions of tools with known vulnerabilities.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Update babel-eslint to 10.0.1.
@nodejs-github-bot
Copy link
Collaborator

@Trott sadly an error occured when I tried to trigger a build :(

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Feb 28, 2019
@Trott
Copy link
Member Author

Trott commented Feb 28, 2019

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 28, 2019
Copy link
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@addaleax
Copy link
Member

addaleax commented Mar 2, 2019

Landed in 536e062

@addaleax addaleax closed this Mar 2, 2019
addaleax pushed a commit that referenced this pull request Mar 2, 2019
Update babel-eslint to 10.0.1.

PR-URL: #26347
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Shingo Inoue <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
addaleax pushed a commit that referenced this pull request Mar 2, 2019
Update babel-eslint to 10.0.1.

PR-URL: #26347
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Shingo Inoue <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Mar 4, 2019
@Trott Trott deleted the update-babel branch January 13, 2022 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants