Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cluster: improve for-loop #26336

Closed
wants to merge 1 commit into from
Closed

cluster: improve for-loop #26336

wants to merge 1 commit into from

Conversation

gengjiawen
Copy link
Member

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the cluster Issues and PRs related to the cluster subsystem. label Feb 27, 2019
@targos
Copy link
Member

targos commented Feb 27, 2019

Since we're not using the keys, it might be even better to do for (const worker of Object.values(cluster.workers)?

@gengjiawen
Copy link
Member Author

@targos done.

@BridgeAR
Copy link
Member

BridgeAR commented Mar 1, 2019

CI https://ci.nodejs.org/job/node-test-pull-request/21096/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 1, 2019
ChALkeR
ChALkeR approved these changes Mar 1, 2019
View reviewed changes
Copy link
Member

@ChALkeR ChALkeR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps also update these lines:
https://github.com/nodejs/node/blob/ea2892bf7beff4e0583df898cfb6b22b45b884a5/lib/internal/cluster/master.js#L227-L228

@gengjiawen
Copy link
Member Author

@ChALkeR done.

@addaleax
Copy link
Member

addaleax commented Mar 2, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/21125/

@BridgeAR
Copy link
Member

BridgeAR commented Mar 4, 2019

Resumed CI https://ci.nodejs.org/job/node-test-pull-request/21178/

@BridgeAR BridgeAR changed the title lib: improve for-loop in master.js cluster: improve for-loop Mar 5, 2019
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 5, 2019
@gengjiawen @BridgeAR
cluster: improve for-loop
e630569 
PR-URL: nodejs#26336
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@BridgeAR
Copy link
Member

BridgeAR commented Mar 5, 2019

Landed in e630569 🎉

@BridgeAR BridgeAR closed this Mar 5, 2019
@gengjiawen gengjiawen deleted the cluster_for_loop branch March 5, 2019 01:13
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 12, 2019
@gengjiawen @BridgeAR
cluster: improve for-loop
2a3cca7 
PR-URL: nodejs#26336
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Mar 13, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Apr 16, 2019
@gengjiawen @BethGriggs
cluster: improve for-loop
fb73c06 
PR-URL: #26336
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@BethGriggs BethGriggs mentioned this pull request May 1, 2019
Merged
This was referenced May 29, 2019
Closed
Closed
This was referenced May 29, 2019
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChALkeR ChALkeR ChALkeR approved these changes

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@targos targos targos approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. cluster Issues and PRs related to the cluster subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@gengjiawen @targos @BridgeAR @addaleax @ChALkeR @jasnell @lpinca @nodejs-github-bot