-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
worker: type error on posting undefined/null message #26123
Conversation
49d2c54
to
835b528
Compare
@addaleax Hola, may I ask you to have a look? :P |
I think this is already addressed by https://github.com/nodejs/node/pull/26082/files#diff-758f6af0d3d1a219d6b5d63cd2e7cc14R65 PTAL. Thanks for a swift fix anyway 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we could keep the test part here anyway? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@addaleax Good idea.
835b528
to
c0f1079
Compare
Conflicts resolved. Now the PR contains tests only. |
c0f1079
to
8ade591
Compare
Looks like it failed for network issues? |
Sorry, I posted a broken link. (Should have been https://ci.nodejs.org/job/node-test-pull-request/20831/.) But anyway, it failed for unrelated reasons, so, resume CI: https://ci.nodejs.org/job/node-test-pull-request/20834/ |
Landed in c077c21, thanks for the PR! 🎉 |
Related: #26122 PR-URL: #26123 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Related: #26122 PR-URL: #26123 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Related: #26122 PR-URL: #26123 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
expecting close #26122
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes