Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

benchmark,test: refactoring #26119

Merged
merged 1 commit into from
Feb 18, 2019
Merged

benchmark,test: refactoring #26119

merged 1 commit into from
Feb 18, 2019

Conversation

refack
Copy link
Contributor

@refack refack commented Feb 15, 2019

Mostly style changes.

  • sorting and minimizing the list of params in the sanity test harness.

Refs: #26101

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@refack build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2615/pipeline

@nodejs-github-bot nodejs-github-bot added benchmark Issues and PRs related to the benchmark subsystem. http Issues or PRs related to the http subsystem. test Issues and PRs related to the tests. labels Feb 15, 2019
@refack refack mentioned this pull request Feb 15, 2019
Merged
3 tasks
@Trott
Copy link
Member

Trott commented Feb 15, 2019

Needs some lint fixes? LGTM otherwise.

@refack refack force-pushed the http-benchmark-cleanup branch from 91d8158 to e3c83d5 Compare February 17, 2019 19:07
@refack
Copy link
Contributor Author

refack commented Feb 17, 2019 •
edited
Loading

Custom CI: https://ci.nodejs.org/job/node-test-commit-custom-suites/877/ ✔️

@refack
Copy link
Contributor Author

refack commented Feb 18, 2019

/CC @nodejs/benchmarking @nodejs/testing PTAL

@refack refack self-assigned this Feb 18, 2019
@refack
benchmark,test: refactoring
c7b6a22 
PR-URL: nodejs#26119
Refs: nodejs#26101
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@refack refack force-pushed the http-benchmark-cleanup branch from e3c83d5 to c7b6a22 Compare February 18, 2019 18:16
@refack refack merged commit c7b6a22 into nodejs:master Feb 18, 2019
@refack refack deleted the http-benchmark-cleanup branch February 18, 2019 18:17
addaleax pushed a commit that referenced this pull request Feb 19, 2019
@refack @addaleax
benchmark,test: refactoring
b50651f 
PR-URL: #26119
Refs: #26101
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Feb 26, 2019
Merged
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@refack @rvagg
benchmark,test: refactoring
f4955fd 
PR-URL: #26119
Refs: #26101
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@refack refack removed their assignment Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
benchmark Issues and PRs related to the benchmark subsystem. http Issues or PRs related to the http subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@refack @nodejs-github-bot @Trott @jasnell @addaleax