Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: get new v8 building for ARM64 Windows #26087

Closed
wants to merge 19 commits into from

Commits on Jan 31, 2019

  1. deps: update V8 to 7.3.492.7

    targos committed Jan 31, 2019
    Configuration menu
    Copy the full SHA
    122a798 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    37e8f30 View commit details
    Browse the repository at this point in the history
  3. src: update NODE_MODULE_VERSION to 70

    Major V8 updates are usually API/ABI incompatible with previous
    versions. This commit adapts NODE_MODULE_VERSION for V8 7.3.
    
    Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md
    targos committed Jan 31, 2019
    Configuration menu
    Copy the full SHA
    aa03cee View commit details
    Browse the repository at this point in the history
  4. deps: sync V8 gypfiles with 7.2

    Co-authored-by: Ujjwal Sharma <[email protected]>
    
    win: add v8_init to dependencies
    
    Fixes: nodejs/node-v8#89
    Co-authored-by: Bartosz Sosnowski <[email protected]>
    targos and bzoz committed Jan 31, 2019
    Configuration menu
    Copy the full SHA
    b803553 View commit details
    Browse the repository at this point in the history
  5. deps: sync V8 gypfiles with 7.3

    ryzokuken authored and targos committed Jan 31, 2019
    Configuration menu
    Copy the full SHA
    ebc1347 View commit details
    Browse the repository at this point in the history
  6. deps: cherry-pick fc0ddf5 from upstream V8

    Original commit message:
    
        [snapshot] Always align embedded blob code pointer and size
    
        Other platforms besides ARM64 Windows may also have alignment
        requirements, e.g. PPC and s390. These requirements may affect
        both the code pointer field and the size field, and so they
        each need alignment directives because they are stored in
        different sections.
    
        Since aligning wastes a handful of bytes at most, not making
        alignment conditional on the platform type seems like a good idea.
    
        Refs: nodejs#24875
        Change-Id: I1f58606af294be65e74a1f107cd05fc21e032704
        Reviewed-on: https://chromium-review.googlesource.com/c/1433778
        Commit-Queue: Jakob Gruber <[email protected]>
        Reviewed-by: Jakob Gruber <[email protected]>
        Cr-Commit-Position: refs/heads/master@{#59058}
    
    Refs: v8/v8@fc0ddf5
    addaleax authored and targos committed Jan 31, 2019
    Configuration menu
    Copy the full SHA
    1ccca91 View commit details
    Browse the repository at this point in the history
  7. deps: bump minimum icu version to 63

    Bump minimum version of ICU needed to build node to 63.
    
    Refs: v8/v8@30a350f
    Co-authored-by: Steven R Loomis <[email protected]>
    2 people authored and targos committed Jan 31, 2019
    Configuration menu
    Copy the full SHA
    1a1872d View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    aa8342d View commit details
    Browse the repository at this point in the history
  9. test: update test-v8-stats

    New heap space: code_large_object_space
    targos committed Jan 31, 2019
    Configuration menu
    Copy the full SHA
    5df0e98 View commit details
    Browse the repository at this point in the history
  10. test: fix tests after V8 update

    Adapt to changes in async stack traces and function name inference
    targos committed Jan 31, 2019
    Configuration menu
    Copy the full SHA
    d2c0250 View commit details
    Browse the repository at this point in the history
  11. test: update postmortem metadata test for V8 7.3

    The V8 7.3 update requires the following adjustments to the
    postmortem debugging metadata constants:
    
    - v8dbg_prop_idx_first was removed in
      v8/v8@1ad0cd5
    
    - v8dbg_jsarray_buffer_was_neutered_mask was renamed to
      v8dbg_jsarray_buffer_was_detached_mask in
      v8/v8@f68ee6e
    
    - v8dbg_jsarray_buffer_was_neutered_shift was renamed to
      v8dbg_jsarray_buffer_was_detached_shift in
      v8/v8@f68ee6e
    
    - v8dbg_class_Map__instance_descriptors__DescriptorArray moved to
      v8dbg_class_Map__raw_instance_descriptors__DescriptorArray and
      began using ACCESSORS2 in
      v8/v8@799dfad
    
    The following postmortem debugging constants were also impacted
    by V8's introduction of ACCESSORS2, but do not need to be updated
    the test:
    
    - v8dbg_class_ThinString__actual__String changed in
      v8/v8@0f581e4
    
    - v8dbg_class_UncompiledData__inferred_name__String changed in
      v8/v8@0f581e4
    
    - v8dbg_class_JSFunction__shared__SharedFunctionInfo changed in
      v8/v8@8162090
    
    - v8dbg_class_SharedFunctionInfo__function_data__Object had its
      accessor removed in
      v8/v8@a55803a
      This has been fixed in gen-postmortem-metadata.py.
    cjihrig authored and targos committed Jan 31, 2019
    Configuration menu
    Copy the full SHA
    938738e View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2019

  1. Configuration menu
    Copy the full SHA
    f33ca57 View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2019

  1. deps: tweak v8 gyp files

    refack committed Feb 2, 2019
    Configuration menu
    Copy the full SHA
    03a4ff0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3cc8b41 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6fe3c17 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    0397f8d View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2019

  1. deps: v8 DISALLOW_IMPLICIT_CONSTRUCTORS for ARM64

    This is a backport of a fix already in upstream v8 that addresses
    errors about TurboAssembler referencing deleted functions.
    jkunkee committed Feb 13, 2019
    Configuration menu
    Copy the full SHA
    c01e512 View commit details
    Browse the repository at this point in the history
  2. deps: v8: add missing source info functions for ARM64

    When source line information was added to v8's mksnapshot process,
    ARM64 was missed. This change adds the missing SourceInfo and
    DeclareExternalFilename definitions.
    
    This change has already been upstreamed.
    jkunkee committed Feb 13, 2019
    Configuration menu
    Copy the full SHA
    56c732a View commit details
    Browse the repository at this point in the history
  3. deps: v8: move function to avoid inline issue

    When building this revision of v8 as a component build using the MSVC
    toolchain targeting ARM64, the link phase emits a missing symbol error
    about XRegFromCode. This change moves the code that generates the
    unfulfilled reference to its corresponding .cc file to avoid the error.
    
    This no longer repros in upstream v8.
    jkunkee committed Feb 13, 2019
    Configuration menu
    Copy the full SHA
    3cb9a54 View commit details
    Browse the repository at this point in the history