Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.msi related cherry picks for v3.x #2608

Closed
wants to merge 2 commits into from
Closed

.msi related cherry picks for v3.x #2608

wants to merge 2 commits into from

Commits on Aug 29, 2015

  1. win,msi: change InstallScope to perMachine 

    This is an adaptation of 8e80528.

Original commit message:

  The MSI install scope was set to the WiX default, which is per-user.
  However, with UAC, it could not be installed by a standard user
  because InstallPrivileges is elevated by default, hence the install
  scope should be set to per-machine. Furthermore, the default install
  path is a per-machine location and setting the system path requires
  administrator privileges.

  By changing the InstallScope to perMachine, Start Menu shortcuts are
  placed in ProgramData and not the installing user's AppData folder,
  making the shortcuts available to other users. This also fixes the
  installation when AppData is a network folder.

  The custom action is necessary to allow upgrades. Since a per-machine
  MSI cannot upgrade an application installed per-user, the custom
  action checks if there is going to be an upgrade to a previous
  version installed per-user and sets the installation as per-user to
  allow upgrading. Hence, the advantages of installing per-machine will
  only apply in fresh installations.

  Fixes nodejs/node-v0.x-archive#5849
  Fixes nodejs/node-v0.x-archive#7629

  PR-URL: nodejs/node-v0.x-archive#25640
  Reviewed-By: Alexis Campailla <[email protected]>
  Reviewed-By: Bert Belder <[email protected]>

The original commit was adapted to search all upgrade codes listed in
the upgrade table, as the current installer tries to upgrade from two
different upgrade codes.

PR-URL: nodejs#2565
Reviewed-By: Alexis Campailla <[email protected]>
    @joaocgreis @rvagg
    joaocgreis authored and rvagg committed Aug 29, 2015
    Configuration menu
    Copy the full SHA
    752977b View commit details
    Browse the repository at this point in the history

  2. win,msi: correct installation path registry keys 

    This is a port of 14db629.

Original commit message:

  Since install is per machine only, installation path should be stored
  in local machine instead of current user. The registry stores HKLM in
  different places for 32 and 64 bit applications, so the installer
  will not suggest the old path when upgrading from 32 to 64 bit
  version.

  Fixes nodejs/node-v0.x-archive#5592
  Fixes nodejs/node-v0.x-archive#25087

  PR-URL: nodejs/node-v0.x-archive#25640
  Reviewed-By: Alexis Campailla <[email protected]>
  Reviewed-By: Bert Belder <[email protected]>

PR-URL: nodejs#2565
Reviewed-By: Alexis Campailla <[email protected]>
    @joaocgreis @rvagg
    joaocgreis authored and rvagg committed Aug 29, 2015
    Configuration menu
    Copy the full SHA
    4f07cab View commit details
    Browse the repository at this point in the history